You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/18 08:57:00 UTC

[GitHub] [kafka] dajac commented on a change in pull request #11225: MINOR; Small optimizations in `ReplicaManager#becomeLeaderOrFollower`

dajac commented on a change in pull request #11225:
URL: https://github.com/apache/kafka/pull/11225#discussion_r691041467



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1436,17 +1438,15 @@ class ReplicaManager(val config: KafkaConfig,
 
           leaderAndIsrRequest.partitionStates.forEach { partitionState =>

Review comment:
       I wonder if we really have to re-iterate over all the partition states present in the request here. Intuitively, I would have thought that considering only the ones in `partitionStates` would be sufficient.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org