(systemds) branch main updated: [MINOR] Deduplicate not-implemented logs in ColGroupTest (#2491)

[ba...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

Baunsgaard pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/systemds.git


The following commit(s) were added to refs/heads/main by this push:
     new 44bb9bfadf [MINOR] Deduplicate not-implemented logs in ColGroupTest (#2491)
44bb9bfadf is described below

commit 44bb9bfadfeb0d83b67fc9c280e4b5a6f41cc97b
Author: Sebastian Baunsgaard <ba...@apache.org>
AuthorDate: Wed Jun 17 16:57:26 2026 +0200

    [MINOR] Deduplicate not-implemented logs in ColGroupTest (#2491)
    
    The parameterized leftMultNoPreAgg test logged the same "not implemented: X or: Y" error for every base/other column group combination, producing hundreds of duplicate lines for shared type pairs. Track already-logged type pairs in a thread-safe set and log each unique permutation at most once per run.
---
 .../test/component/compress/colgroup/ColGroupTest.java      | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/test/java/org/apache/sysds/test/component/compress/colgroup/ColGroupTest.java b/src/test/java/org/apache/sysds/test/component/compress/colgroup/ColGroupTest.java
index 4c5fc3bd8a..71c9c0ce54 100644
--- a/src/test/java/org/apache/sysds/test/component/compress/colgroup/ColGroupTest.java
+++ b/src/test/java/org/apache/sysds/test/component/compress/colgroup/ColGroupTest.java
@@ -29,6 +29,8 @@ import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.Random;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 
 import org.apache.commons.lang3.NotImplementedException;
 import org.apache.commons.logging.Log;
@@ -92,6 +94,9 @@ import org.junit.runners.Parameterized;
 public class ColGroupTest extends ColGroupBase {
 	protected static final Log LOG = LogFactory.getLog(ColGroupTest.class.getName());
 
+	/** Tracks already-logged "not implemented" column group type pairs to avoid duplicate log spam. */
+	private static final Set<String> loggedNotImplemented = ConcurrentHashMap.newKeySet();
+
 	public ColGroupTest(AColGroup base, AColGroup other, int nRow) {
 		super(base, other, nRow);
 	}
@@ -1282,7 +1287,7 @@ public class ColGroupTest extends ColGroupBase {
 			compare(bt, ot);
 		}
 		catch(NotImplementedException e) {
-			LOG.error("not implemented: " + base.getClass().getSimpleName() + " or: " + other.getClass().getSimpleName());
+			logNotImplementedOnce();
 		}
 		catch(Exception e) {
 			e.printStackTrace();
@@ -1290,6 +1295,12 @@ public class ColGroupTest extends ColGroupBase {
 		}
 	}
 
+	private void logNotImplementedOnce() {
+		final String pair = base.getClass().getSimpleName() + " or: " + other.getClass().getSimpleName();
+		if(loggedNotImplemented.add(pair))
+			LOG.error("not implemented: " + pair);
+	}
+
 	@Test
 	public void sparseSelection() {
 		MatrixBlock mb = CLALibSelectionMultTest.createSelectionMatrix(nRow, 5, false);