You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/06/07 19:53:41 UTC
[GitHub] [airflow] potiuk opened a new pull request, #31780: Fix Databricks SQL operator serialization
potiuk opened a new pull request, #31780:
URL: https://github.com/apache/airflow/pull/31780
The Databricks SQL operator returned Databricks Row which were not serializatble, because they were special extension of tuples that also acted as dict. In case of SQLOperator, we return a different format of output - separately descriptions of the rows and separately rows of values which are regular tuples.
This PR converts the Databrick Rows into regular tuples on the flight while processing the output
Fixes: #31753
Fixes: #31499
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #31780: Fix Databricks SQL operator serialization
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #31780:
URL: https://github.com/apache/airflow/pull/31780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #31780: Fix Databricks SQL operator serialization
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #31780:
URL: https://github.com/apache/airflow/pull/31780#discussion_r1222866670
##########
tests/providers/databricks/operators/test_databricks_sql.py:
##########
@@ -22,10 +22,10 @@
from unittest.mock import patch
import pytest
-from databricks.sql.types import Row
Review Comment:
Sorry. have not seen it before merging. It's a left-over from some other trials done - not a big harm, it's the same Row just imported from `databricks_sql` - so it actually might even make more sense to be imported from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #31780: Fix Databricks SQL operator serialization
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #31780:
URL: https://github.com/apache/airflow/pull/31780#discussion_r1222665506
##########
tests/providers/databricks/operators/test_databricks_sql.py:
##########
@@ -22,10 +22,10 @@
from unittest.mock import patch
import pytest
-from databricks.sql.types import Row
Review Comment:
Why change this import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #31780: Fix Databricks SQL operator serialization
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #31780:
URL: https://github.com/apache/airflow/pull/31780#issuecomment-1582359967
> This solution works ! I have tested it on my local and here are the logs
Coool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org