[GitHub] [jena] afs commented on pull request #1337: Quoted LOGGING variable in fuseki-server script.

[GitBox <gi...@apache.org>]

afs commented on PR #1337:
URL: https://github.com/apache/jena/pull/1337#issuecomment-1140456487

   Hi @swartik -- a couple of problems:
   
   * It's a sh script, not a bash script so `@Q` is not available. (We can switch to bash.)
   * if it is bash, the substitution does not seem to work (reading the man age, I think it should but it doesn't. Bash version 5.1.16).
    
   How about this approach:
   
   ```
   if [ -n "$LOGGING" ]
   then
       exec "$JAVA" $JVM_ARGS "$LOGGING" -cp "$CP" org.apache.jena.fuseki.cmd.FusekiCmd "$@"
   else
       exec "$JAVA" $JVM_ARGS -cp "$CP" org.apache.jena.fuseki.cmd.FusekiCmd "$@"
   fi
   ```
   
   I've tested it with FUSKEI_HOME set to a directory path with a space in it. Could you confirm please? What in the path does your setup have the space?
   
   There is an unrelated problem with some cases of FUSEKI_BASE including a path with a space. This is a separate issue not related to the script.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org