You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/24 06:11:21 UTC
[GitHub] [superset] MaxHuiYYDS opened a new pull request #16418: Fix(Explore control panel) native keyboard tab
MaxHuiYYDS opened a new pull request #16418:
URL: https://github.com/apache/superset/pull/16418
### SUMMARY
Explore control panel:
I added hideNativeTab prop at ControlHeader in selectControl, when the native keyboard Tab actions need to omit the headers, then define the hideNativeTab to true.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER：
https://user-images.githubusercontent.com/51693396/130355613-79b19e53-4bcd-4b18-9871-3abb04ff0aca.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #16365, #14574
- [] Required feature flags:
- [x] Changes UI
- [] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [] Migration is atomic, supports rollback & is backwards-compatible
- [] Confirm DB migration upgrade and downgrade tested
- [] Runtime estimates and downtime expectations provided
- [] Introduces new feature or API
- [] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-907373829
Do we know why the tests fail? We can't just disable tests unless the change of behavior is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on a change in pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on a change in pull request #16418:
URL: https://github.com/apache/superset/pull/16418#discussion_r695328953
##########
File path: superset-frontend/src/explore/components/ControlHeader.jsx
##########
@@ -37,13 +37,15 @@ const propTypes = {
tooltipOnClick: PropTypes.func,
warning: PropTypes.string,
danger: PropTypes.string,
+ hideNativeTab: PropTypes.bool,
Review comment:
I was consider not to affect other components except the #14574 bug one, do we need to skip all the focus that components includes ControlHeader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16418: Fix(Explore control panel): native keyboard tab
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904819350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16418: Fix(Explore control panel): native keyboard tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904818892
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904839804
# [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16418](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d75898d) into [master](https://codecov.io/gh/apache/superset/commit/486ef6b81fb0eab39a3e403bb7fdba784c5e8649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486ef6b) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d75898d differs from pull request most recent head 0748cac. Consider uploading reports for the commit 0748cac to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16418 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 1000 1000
Lines 53487 53491 +4
Branches 6818 6822 +4
=======================================
+ Hits 40948 40952 +4
Misses 12301 12301
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.69% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `87.50% <100.00%> (+1.29%)` | :arrow_up: |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `89.47% <100.00%> (+0.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [486ef6b...0748cac](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904839804
# [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16418](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d75898d) into [master](https://codecov.io/gh/apache/superset/commit/486ef6b81fb0eab39a3e403bb7fdba784c5e8649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486ef6b) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d75898d differs from pull request most recent head f8dd972. Consider uploading reports for the commit f8dd972 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16418 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 1000 1000
Lines 53487 53491 +4
Branches 6818 6822 +4
=======================================
+ Hits 40948 40952 +4
Misses 12301 12301
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.69% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `87.50% <100.00%> (+1.29%)` | :arrow_up: |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `89.47% <100.00%> (+0.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [486ef6b...f8dd972](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on a change in pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on a change in pull request #16418:
URL: https://github.com/apache/superset/pull/16418#discussion_r695328953
##########
File path: superset-frontend/src/explore/components/ControlHeader.jsx
##########
@@ -37,13 +37,15 @@ const propTypes = {
tooltipOnClick: PropTypes.func,
warning: PropTypes.string,
danger: PropTypes.string,
+ hideNativeTab: PropTypes.bool,
Review comment:
I was consider not affect other components except the #14574 bug one, do we need to skip all the focus that components includes ControlHeader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #16418:
URL: https://github.com/apache/superset/pull/16418#discussion_r695329891
##########
File path: superset-frontend/src/explore/components/ControlHeader.jsx
##########
@@ -37,13 +37,15 @@ const propTypes = {
tooltipOnClick: PropTypes.func,
warning: PropTypes.string,
danger: PropTypes.string,
+ hideNativeTab: PropTypes.bool,
Review comment:
ControlHeader is only used on the Explore page, if we want to change this focus behavior, we probably want to change it for all control headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904839804
# [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16418](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d75898d) into [master](https://codecov.io/gh/apache/superset/commit/486ef6b81fb0eab39a3e403bb7fdba784c5e8649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486ef6b) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d75898d differs from pull request most recent head 0853859. Consider uploading reports for the commit 0853859 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16418 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 1000 1000
Lines 53487 53491 +4
Branches 6818 6822 +4
=======================================
+ Hits 40948 40952 +4
Misses 12301 12301
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.69% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `87.50% <100.00%> (+1.29%)` | :arrow_up: |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `89.47% <100.00%> (+0.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [486ef6b...0853859](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on pull request #16418: Fix(Explore control panel) native keyboard tab
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904353339
@junlincc @ktmud please help review, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on a change in pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on a change in pull request #16418:
URL: https://github.com/apache/superset/pull/16418#discussion_r695333995
##########
File path: superset-frontend/src/explore/components/ControlHeader.jsx
##########
@@ -37,13 +37,15 @@ const propTypes = {
tooltipOnClick: PropTypes.func,
warning: PropTypes.string,
danger: PropTypes.string,
+ hideNativeTab: PropTypes.bool,
Review comment:
@ktmud Done, changed to skipTabFocus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904839804
# [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16418](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d40847) into [master](https://codecov.io/gh/apache/superset/commit/486ef6b81fb0eab39a3e403bb7fdba784c5e8649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486ef6b) will **increase** coverage by `0.14%`.
> The diff coverage is `77.29%`.
> :exclamation: Current head 5d40847 differs from pull request most recent head b2fd637. Consider uploading reports for the commit b2fd637 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16418 +/- ##
==========================================
+ Coverage 76.55% 76.70% +0.14%
==========================================
Files 1000 1002 +2
Lines 53487 53683 +196
Branches 6818 6855 +37
==========================================
+ Hits 40948 41176 +228
+ Misses 12301 12270 -31
+ Partials 238 237 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.01% <75.00%> (+0.31%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (ø)` | |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/TableView/TableView.tsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVWaWV3L1RhYmxlVmlldy50c3g=) | `94.52% <ø> (ø)` | |
| [superset-frontend/src/dashboard/actions/hydrate.js](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2h5ZHJhdGUuanM=) | `1.72% <ø> (+0.02%)` | :arrow_up: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `78.84% <ø> (ø)` | |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `69.49% <ø> (ø)` | |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `100.00% <ø> (ø)` | |
| [...rontend/src/dashboard/containers/DashboardPage.tsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZFBhZ2UudHN4) | `0.00% <0.00%> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `76.47% <ø> (ø)` | |
| [.../components/ExploreAdditionalActionsMenu/index.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWRkaXRpb25hbEFjdGlvbnNNZW51L2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| ... and [104 more](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [486ef6b...b2fd637](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #16418:
URL: https://github.com/apache/superset/pull/16418#discussion_r695047564
##########
File path: superset-frontend/src/explore/components/ControlHeader.jsx
##########
@@ -37,13 +37,15 @@ const propTypes = {
tooltipOnClick: PropTypes.func,
warning: PropTypes.string,
danger: PropTypes.string,
+ hideNativeTab: PropTypes.bool,
Review comment:
Can we name this `skipTabFocus`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #16418:
URL: https://github.com/apache/superset/pull/16418#discussion_r695047564
##########
File path: superset-frontend/src/explore/components/ControlHeader.jsx
##########
@@ -37,13 +37,15 @@ const propTypes = {
tooltipOnClick: PropTypes.func,
warning: PropTypes.string,
danger: PropTypes.string,
+ hideNativeTab: PropTypes.bool,
Review comment:
Can we name this `skipTabFocus` or `focusable` (with a default == true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-904839804
# [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16418](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d75898d) into [master](https://codecov.io/gh/apache/superset/commit/486ef6b81fb0eab39a3e403bb7fdba784c5e8649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (486ef6b) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head d75898d differs from pull request most recent head b2fd637. Consider uploading reports for the commit b2fd637 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16418 +/- ##
=======================================
Coverage 76.55% 76.55%
=======================================
Files 1000 1000
Lines 53487 53491 +4
Branches 6818 6822 +4
=======================================
+ Hits 40948 40952 +4
Misses 12301 12301
Partials 238 238
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `70.69% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `87.50% <100.00%> (+1.29%)` | :arrow_up: |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/16418/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `89.47% <100.00%> (+0.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [486ef6b...b2fd637](https://codecov.io/gh/apache/superset/pull/16418?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on pull request #16418: fix(explore): skip Tab focus on control headers
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on pull request #16418:
URL: https://github.com/apache/superset/pull/16418#issuecomment-907140064
@ktmud I have Annotated some button click test, to make this PR pass the test, please help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org