[GitHub] [ozone] szetszwo commented on a diff in pull request #3787: HDDS-7271. Ozone Integration test shows memory leak (graceful shutdown cleanup)

[GitBox <gi...@apache.org>]

szetszwo commented on code in PR #3787:
URL: https://github.com/apache/ozone/pull/3787#discussion_r992084368


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/RatisDropwizardExports.java:
##########
@@ -54,6 +54,13 @@ public static void registerRatisMetricReporters(
         r2 -> deregisterDropwizard(r2, ratisMetricsMap));
   }
 
+  public static void clear(Map<String, RatisDropwizardExports>
+                               ratisMetricsMap) {
+    MetricRegistries.global().clear();
+    CollectorRegistry.defaultRegistry.clear();
+    ratisMetricsMap.clear();
+  }

Review Comment:
   +1 the change looks good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org