You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 17:30:42 UTC
[GitHub] [airflow] hnaoto opened a new pull request #12316: add install/uninstall api to databricks hook
hnaoto opened a new pull request #12316:
URL: https://github.com/apache/airflow/pull/12316
- adding install Databricks API to databricks hook([api/2.0/libraries/install](https://docs.databricks.com/dev-tools/api/latest/libraries.html#install))
- adding uninstall Databricks API to databricks hook ([2.0/libraries/uninstall](https://docs.databricks.com/dev-tools/api/latest/libraries.html#uninstall))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726300132
[The Workflow run](https://github.com/apache/airflow/actions/runs/360312926) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726283510
> So far my only comment is on the docstring’s summary line. Would be good to be consistent with the “style” of existing methods, like “Terminates the cluster”/“Starts the cluster”/etc. above
To clarify myself a bit: I meant to ADD a summary line in the existing “style”. The current line can be kept and I find them useful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726252909
[The Workflow run](https://github.com/apache/airflow/actions/runs/360210343) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726498337
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726349671
[The Workflow run](https://github.com/apache/airflow/actions/runs/360474569) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hnaoto commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
hnaoto commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726450217
> > So far my only comment is on the docstring’s summary line. Would be good to be consistent with the “style” of existing methods, like “Terminates the cluster”/“Starts the cluster”/etc. above
>
> To clarify myself a bit: I meant to ADD a summary line in the existing “style”. The current line can be kept and I find them useful
Thank you! just added a "summary line" in the comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726224501
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726555853
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #12316:
URL: https://github.com/apache/airflow/pull/12316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12316: add install/uninstall api to databricks hook
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12316:
URL: https://github.com/apache/airflow/pull/12316#issuecomment-726556153
Thanks @hnaoto . Look forward to the next PR from you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org