[GitHub] [superset] hughhhh commented on a diff in pull request #24196: fix: SSH Tunnel creation with dynamic form

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #24196:
URL: https://github.com/apache/superset/pull/24196#discussion_r1238961750


##########
superset-frontend/src/features/databases/DatabaseModal/index.tsx:
##########
@@ -763,15 +763,18 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
         });
       }
 
-      // make sure that button spinner animates
-      setLoading(true);
-      const errors = await getValidation(dbToUpdate, true);
-      if ((validationErrors && !isEmpty(validationErrors)) || errors) {
+      // only do validation for non ssh tunnel connections
+      if (!dbToUpdate?.ssh_tunnel) {

Review Comment:
   for the initial implementation, we were okay with doing validation on just connect. Right now users are not able to connect at all via dynamic forms.
   
   I'm open to this fix but that's going to take longer to implement vs. fixing the issue at hand.
   
   Let me know what you think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org