You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Anubhav Sharma (JIRA)" <ji...@apache.org> on 2011/08/22 14:25:29 UTC

[jira] [Created] (WSS-312) Improve logging levels

Improve logging levels
----------------------

                 Key: WSS-312
                 URL: https://issues.apache.org/jira/browse/WSS-312
             Project: WSS4J
          Issue Type: Improvement
          Components: WSS4J Core
    Affects Versions: 1.6.2
            Reporter: Anubhav Sharma
            Assignee: Colm O hEigeartaigh
            Priority: Minor
             Fix For: 1.6.3
         Attachments: 0001-Improved-logging-levels.patch

In the source code at most of the places where exception is thrown, exception is logged at debug level. Ideally it should be at warn or error level. This would improve overall logging in the library.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Commented] (WSS-312) Improve logging levels

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088731#comment-13088731 ] 

Andreas Veithen commented on WSS-312:
-------------------------------------

I fully agree with Dan's comment. This is indeed an anti-pattern.

> Improve logging levels
> ----------------------
>
>                 Key: WSS-312
>                 URL: https://issues.apache.org/jira/browse/WSS-312
>             Project: WSS4J
>          Issue Type: Improvement
>          Components: WSS4J Core
>    Affects Versions: 1.6.2
>            Reporter: Anubhav Sharma
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 1.6.3
>
>         Attachments: 0001-Improved-logging-levels.patch
>
>
> In the source code at most of the places where exception is thrown, exception is logged at debug level. Ideally it should be at warn or error level. This would improve overall logging in the library.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Commented] (WSS-312) Improve logging levels

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088718#comment-13088718 ] 

Daniel Kulp commented on WSS-312:
---------------------------------


I have to say that I disagree with this patch.    This is really a "log and rethrow" anti-pattern which, to me, is a bad idea.    Let the caller catch the exception and determine if the right thing to do is log the exception at whatever log level is appropriate or handle it or whatever.    


> Improve logging levels
> ----------------------
>
>                 Key: WSS-312
>                 URL: https://issues.apache.org/jira/browse/WSS-312
>             Project: WSS4J
>          Issue Type: Improvement
>          Components: WSS4J Core
>    Affects Versions: 1.6.2
>            Reporter: Anubhav Sharma
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 1.6.3
>
>         Attachments: 0001-Improved-logging-levels.patch
>
>
> In the source code at most of the places where exception is thrown, exception is logged at debug level. Ideally it should be at warn or error level. This would improve overall logging in the library.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Updated] (WSS-312) Improve logging levels

Posted by "Anubhav Sharma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anubhav Sharma updated WSS-312:
-------------------------------

    Attachment: 0001-Improved-logging-levels.patch

Improved logging levels. Instead of exceptions being logged at debug level, changed to error and warn.

> Improve logging levels
> ----------------------
>
>                 Key: WSS-312
>                 URL: https://issues.apache.org/jira/browse/WSS-312
>             Project: WSS4J
>          Issue Type: Improvement
>          Components: WSS4J Core
>    Affects Versions: 1.6.2
>            Reporter: Anubhav Sharma
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 1.6.3
>
>         Attachments: 0001-Improved-logging-levels.patch
>
>
> In the source code at most of the places where exception is thrown, exception is logged at debug level. Ideally it should be at warn or error level. This would improve overall logging in the library.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Resolved] (WSS-312) Improve logging levels

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh resolved WSS-312.
-------------------------------------

    Resolution: Won't Fix


Thanks for the patch, but changing the logging levels will lead to too many stacktraces in the logs etc. It's up to the calling application to log errors at a higher level.

Colm.

> Improve logging levels
> ----------------------
>
>                 Key: WSS-312
>                 URL: https://issues.apache.org/jira/browse/WSS-312
>             Project: WSS4J
>          Issue Type: Improvement
>          Components: WSS4J Core
>    Affects Versions: 1.6.2
>            Reporter: Anubhav Sharma
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 1.6.3
>
>         Attachments: 0001-Improved-logging-levels.patch
>
>
> In the source code at most of the places where exception is thrown, exception is logged at debug level. Ideally it should be at warn or error level. This would improve overall logging in the library.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org


[jira] [Closed] (WSS-312) Improve logging levels

Posted by "Colm O hEigeartaigh (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSS-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh closed WSS-312.
-----------------------------------

    
> Improve logging levels
> ----------------------
>
>                 Key: WSS-312
>                 URL: https://issues.apache.org/jira/browse/WSS-312
>             Project: WSS4J
>          Issue Type: Improvement
>          Components: WSS4J Core
>    Affects Versions: 1.6.2
>            Reporter: Anubhav Sharma
>            Assignee: Colm O hEigeartaigh
>            Priority: Minor
>             Fix For: 1.6.3
>
>         Attachments: 0001-Improved-logging-levels.patch
>
>
> In the source code at most of the places where exception is thrown, exception is logged at debug level. Ideally it should be at warn or error level. This would improve overall logging in the library.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org