You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Kurt Roekle (JIRA)" <ji...@apache.org> on 2007/05/18 20:50:16 UTC
[jira] Created: (WICKET-579) Need for DataTable not to require size
Need for DataTable not to require size
--------------------------------------
Key: WICKET-579
URL: https://issues.apache.org/jira/browse/WICKET-579
Project: Wicket
Issue Type: Improvement
Components: wicket, wicket-extensions
Affects Versions: 1.3.0-beta1
Environment: 1.3 snapshot dated 4/25
Reporter: Kurt Roekle
Attachments: wicket-toolbar.jar
Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
AbstractPageableView: 70,97,137,139,142-149
DataTable: 120-122
NavigationToolbar: 39,49,60,64,88,104
PagingNavigator: 48,62-66,81,97,110
NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-579) Need for DataTable not to require size
Posted by "Kurt Roekle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kurt Roekle updated WICKET-579:
-------------------------------
Attachment: wicket-toolbar.jar
source code for my fix
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Kurt Roekle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510372 ]
Kurt Roekle commented on WICKET-579:
------------------------------------
The only way I could find to get around calling size was to rewrite
DataTable and AbstractPageableView (which really means rewriting the
whole hierarchy). I wanted to reuse the existing (and very feature
rich) code with as little impact as possible, so I had to bring in a
new interface & abstract class (SizeCachingDataProvider &
EPagingDataProvider) that need to be used in conjunction with the new
toolbar (or the updated old one). I thought I put this in the
javadoc, but I guess I missed that.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: WICKET-578.patch, wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503879 ]
Alastair Maw commented on WICKET-579:
-------------------------------------
Come come, let's not start throwing our toys out of the pram - it's really not very productive.
I was hopeful that you might be able to provide a patch, given you said, "I currently can't give you a diff", implying that you might be able to in future, hence the request. You certainly haven't wasted anyone's time, it's just that we're very busy trying to get 1.3.0 out the door at the moment, and we have a lot of patches and issues to look at and resolve.
Providing a patch makes our lives much easier, as we're able to see at a glance the extent of the impact of the changes. We otherwise have to work out which revision number your changes are against (stuff has changed in the files since then, so we can't just overwrite them), create a diff against that, review it, and apply it to the current trunk. We're all very busy and aren't getting paid to do this stuff. Please try to meet us half way here...
Given no one's voting for or watching this bug and that the mailing list thread about it didn't prompt anyone to come out of the woodwork and say they really want this feature, it's just not such high priority as other things, I'm afraid. Given we're in a feature freeze for 1.3 at the moment (and this is a new feature) as things stand, this is likely to languish until we have 1.3.0 out the door before someone gets around to looking at it. As stated, if you can provide a patch to make the barrier to entry for fixing this a little lower, it'll probably get done a little sooner.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Assignee: Alastair Maw
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500152 ]
Eelco Hillenius commented on WICKET-579:
----------------------------------------
If you don't know the exact size for whatever reason, why don't you let size return an estimate that works in your case?
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497054 ]
Igor Vaynberg commented on WICKET-579:
--------------------------------------
the size is only cached within the scope of the request, not across requests. it is necessary so that we can compute how many pages of data there are. i really dont see what value these changes bring.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Kurt Roekle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503863 ]
Kurt Roekle commented on WICKET-579:
------------------------------------
Actually it's not easy at all to duplicate the functionality of DataTable. I would have to duplicate 10+ classes with several hundred lines of code and then lose any new functionality that would be included in new versions of DataTable. That was the path I started to go down before I found a way to do it with < 20 lines of code with the patch I submitted. The AbstractPageableView, DataTable and new interface would be all that's needed to "enable" me to create my own toolbar to do this. I included two implementations to utilize this in the DataTable, first was using the existing NavigationToolbar and the second was to create a new toolbar. None of the changes I submitted will have any effect on existing code. I'm sorry that I cannot submit a "patch" file as the client I am working for does not allow subversion access. I've submitted many patches to other oss projects in this way without meeting this kind of resistance (most projects are happy to receive code any way they can get it). Since originally submitting this enhancement the project I'm on has chosen to go another direction, so I cannot spend more time on this. I'm truly sorry if your project feels I wasted your time on submitting this enhancement, it was not my intent. I truly believe in submitting code back to oss and that was all I was trying to do.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Assignee: Alastair Maw
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Kurt Roekle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500158 ]
Kurt Roekle commented on WICKET-579:
------------------------------------
If the estimated size is less then the actually size, then DataTable will not display the "extra rows" (DataTable only requests from the iterator method up to what's returned from the size method). And if the estimated size is greater then the actual size, you get extra blank pages (which DataTable handles ok). It also doesn't address the performance concerns, it could be just as costly to come up with an estimate then with an actual size.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-579) Need for DataTable not to require
size
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw reassigned WICKET-579:
-----------------------------------
Assignee: Alastair Maw
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Assignee: Alastair Maw
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509256 ]
Gwyn Evans commented on WICKET-579:
-----------------------------------
I'd not noticed this till now, but will have a look to see if I can help move it on.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Kurt Roekle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497075 ]
Kurt Roekle commented on WICKET-579:
------------------------------------
That's the point, I don't want to run a size query at all. Why do two queries when it's not necessary. The number of pages really does no good, and may even change after the size query and before the iterator query. The changes I submitted do not show the "of #" or go to last page link, it gets data one page at a time (when requested) and when there are less rows then requested it knows it's at the end.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-579) Need for DataTable not to require size
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-579:
--------------------------------
Assignee: (was: Alastair Maw)
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-579) Need for DataTable not to require size
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gwyn Evans updated WICKET-579:
------------------------------
Attachment: WICKET-578.patch
Patched against trunk r552185.
I can see what he's trying to do, but I think that it's still not 100% there, as his EPagingNavigator (used by ENavigationToolbar,) still uses a PagingNavigation, which does a IPageable.getPageCount(), which will end up in IDataProvider.size().
I could well be missing something, though...
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: WICKET-578.patch, wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-579) Need for DataTable not to require
size
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503212 ]
Alastair Maw commented on WICKET-579:
-------------------------------------
I'm very tempted to wontfix this, as this isn't really what the data table was intended to do, and it's pretty easy to write your own classes for dealing with unbounded datasets, with "more..." links.
I'm afraid I think we're quite unlikely to put this functionality in unless you can provide us with some patches that have minimal impact on the existing code and zero impact on current functionality.
A JAR file isn't awfully helpful.
Check out the code using Subversion (instructions are on the wiki) and when you have modified it, do an "svn diff > WICKET-578.patch" from the root directory of the Wicket project, and upload that file here, and I'll take another look at this.
> Need for DataTable not to require size
> --------------------------------------
>
> Key: WICKET-579
> URL: https://issues.apache.org/jira/browse/WICKET-579
> Project: Wicket
> Issue Type: Improvement
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.0-beta1
> Environment: 1.3 snapshot dated 4/25
> Reporter: Kurt Roekle
> Attachments: wicket-toolbar.jar
>
>
> Requiring a size query for the DataProvider passed to the DataTable hurts performance and scalability (not to mention, it wont be accurate in a system when a lot of updates/deletes are taking place). I had hoped to be able to code just a new toolbar and DataProvider that would fix this, but I found I needed changes in DataTable and AbstractPageableView due to the fact AbstractPageableView caches the row count. I've made fixes for DataTable and AbstractPageableView and I've included one new interface that would be required. I've also added an implementation of a new toolbar and DataProvider that will enable DataTable to work without size (I've also included a modified NavigationToolbar (and friends) that could be implemented instead of a new toolbar. I've tested these changes with my limited knowledge of wicket and they seem to not break any existing code. I currently can't give you a diff, but the line #'s that changed are as follows:
>
> AbstractPageableView: 70,97,137,139,142-149
> DataTable: 120-122
> NavigationToolbar: 39,49,60,64,88,104
> PagingNavigator: 48,62-66,81,97,110
> NavigatorLabel: 42,54,74
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.