[GitHub] jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

[GitBox <gi...@apache.org>]

jkrdev commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs
URL: https://github.com/apache/accumulo/pull/341#discussion_r157232268
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java
 ##########
 @@ -428,6 +428,7 @@ public void testDeniedAudits() throws AccumuloSecurityException, AccumuloExcepti
     try {
       Scanner scanner = auditConnector.createScanner(OLD_TEST_TABLE_NAME, auths);
       scanner.iterator().next().getKey();
+      scanner.close();
 
 Review comment:
   Oh you are so right, I didn't even think of just putting the scanner objects in the try loops if there is one.  some of the scanners weren't in try-with-resources already so I just closed them where they were. I will make that change where possible. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services