You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/06 20:40:24 UTC

Review Request 16658: Added a patch for glog required when compiling with clang.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16658/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 068b17bea2eca96de1fc2a3fd0608a1dde38eeb3 
  3rdparty/libprocess/3rdparty/glog-0.3.3.patch PRE-CREATION 

Diff: https://reviews.apache.org/r/16658/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 16658: Added a patch for glog required when compiling with clang.

Posted by Ben Mahler <be...@gmail.com>.

> On Jan. 6, 2014, 10:16 p.m., Niklas Nielsen wrote:
> > Is it worthwhile mentioning why the patch is applied? The patch is from a particular bug/issue, right?

+1 :)


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16658/#review31279
-----------------------------------------------------------


On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16658/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 7:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 068b17bea2eca96de1fc2a3fd0608a1dde38eeb3 
>   3rdparty/libprocess/3rdparty/glog-0.3.3.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16658/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 16658: Added a patch for glog required when compiling with clang.

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Jan. 6, 2014, 10:16 p.m., Niklas Nielsen wrote:
> > Is it worthwhile mentioning why the patch is applied? The patch is from a particular bug/issue, right?
> 
> Ben Mahler wrote:
>     +1 :)

Done. And also explained why we have the libev patch. Thanks for suggesting this!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16658/#review31279
-----------------------------------------------------------


On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16658/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 7:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 068b17bea2eca96de1fc2a3fd0608a1dde38eeb3 
>   3rdparty/libprocess/3rdparty/glog-0.3.3.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16658/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 16658: Added a patch for glog required when compiling with clang.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16658/#review31279
-----------------------------------------------------------

Ship it!


Is it worthwhile mentioning why the patch is applied? The patch is from a particular bug/issue, right?

- Niklas Nielsen


On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16658/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 7:40 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 068b17bea2eca96de1fc2a3fd0608a1dde38eeb3 
>   3rdparty/libprocess/3rdparty/glog-0.3.3.patch PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16658/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>