You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/22 01:30:45 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12096: [BUG]Delete Setting ID

caishunfeng commented on code in PR #12096:
URL: https://github.com/apache/dolphinscheduler/pull/12096#discussion_r977104771


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -1315,7 +1315,6 @@ protected boolean checkAndImport(User loginUser, long projectCode, Map<String, O
             return false;
         }
         processDefinition.setName(importProcessDefinitionName);
-        processDefinition.setId(0);

Review Comment:
   When import workflow, it should create a new id, so it's better to setId(null), but not use the origin id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org