[I] [Bug] the thrift plugin in javaagent doesn't handle exceptions. [skywalking]

["h0cheung (via GitHub)" <gi...@apache.org>]

h0cheung opened a new issue, #12299:
URL: https://github.com/apache/skywalking/issues/12299

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   Java Agent (apache/skywalking-java)
   
   ### What happened
   
   The thrift plugin can't handle exceptions.
   
   [The `ProcessFunction` has caught all exceptions except `TTransportException` for many years.](https://github.com/apache/thrift/commit/026c9d032c4a298ecb9edbcdfb52590facb442f3) So the plugin, which enhances `TBaseProcessor` cannot catch the exceptions. Then thrift server spans will never have errors unless a transport exception happens.
   
   On the client side, the plugin works well. The thrift client spans will have errors when an exception happens.
   
   ### What you expected to happen
   
   If an exception happens, both server and client should have errors.
   
   ### How to reproduce
   
   Run a thrift server, which throw an custom Exception that will be returned to thrift client.
   
   Then send requests to this server.
   
   ### Anything else
   
   [For gRPC, the status code in response will be used to find errors.](https://github.com/apache/skywalking-java/blob/313d7d5c8e171df0a24b273c4949738133586922/apm-sniffer/apm-sdk-plugin/grpc-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/grpc/v1/server/TracingServerCall.java) Maybe we should try to handle the response sent by thrift server.
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [ ] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] the thrift plugin in javaagent doesn't handle exceptions. [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng closed issue #12299: [Bug] the thrift plugin in javaagent doesn't handle exceptions.
URL: https://github.com/apache/skywalking/issues/12299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org