You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/31 18:37:38 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9062:
[fix] Ensure that is_adhoc_metric returns a boolean
john-bodley opened a new pull request #9062: [fix] Ensure that is_adhoc_metric returns a boolean
URL: https://github.com/apache/incubator-superset/pull/9062
### CATEGORY
Choose one
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
This PR ensures that the `is_adhoc_metric` method returns a boolean. Previous it could return a string as some of the expressions evaluate to a string.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460 @michellethomas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9062:
[fix] Ensure that is_adhoc_metric returns a boolean
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9062: [fix] Ensure that is_adhoc_metric returns a boolean
URL: https://github.com/apache/incubator-superset/pull/9062#issuecomment-580880170
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=h1) Report
> Merging [#9062](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bbe433784d232538a9ed17edb9d7e5aaa0f39b0d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9062 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11747 11747
Branches 2888 2888
=======================================
Hits 6984 6984
Misses 4584 4584
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=footer). Last update [bbe4337...4972849](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9062: [fix]
Ensure that is_adhoc_metric returns a boolean
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9062: [fix] Ensure that is_adhoc_metric returns a boolean
URL: https://github.com/apache/incubator-superset/pull/9062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9062: [fix]
Ensure that is_adhoc_metric returns a boolean
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9062: [fix] Ensure that is_adhoc_metric returns a boolean
URL: https://github.com/apache/incubator-superset/pull/9062#issuecomment-580880170
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=h1) Report
> Merging [#9062](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bbe433784d232538a9ed17edb9d7e5aaa0f39b0d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9062 +/- ##
=======================================
Coverage 59.45% 59.45%
=======================================
Files 369 369
Lines 11747 11747
Branches 2888 2888
=======================================
Hits 6984 6984
Misses 4584 4584
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=footer). Last update [bbe4337...4972849](https://codecov.io/gh/apache/incubator-superset/pull/9062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org