You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by JonathanH5 <gi...@git.apache.org> on 2014/07/29 15:16:28 UTC

[GitHub] incubator-flink pull request: Improved WebClient

GitHub user JonathanH5 opened a pull request:

    https://github.com/apache/incubator-flink/pull/82

    Improved WebClient

    I did the following things:
    *display temp_mode at edge
    *simplified function loadJsonToDagre(data);
    *removed small grey borders below colored borders
    *mirrored node into iteration if the origin is outside to draw an edge
    
    Added working zoom buttons in planVisualizer.html
    
    Added zoom buttons to hole webclient

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JonathanH5/incubator-flink client

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
    
----
commit e61415be3508ae7717485598dd945f22c166799e
Author: Jonathan <jo...@hasenburg.de>
Date:   2014-07-19T15:46:56Z

    Improved WebClient
    
    I did the following things:
    *display temp_mode at edge
    *simplified function loadJsonToDagre(data);
    *removed small grey borders below colored borders
    *mirrored node into iteration if the origin is outside to draw an edge
    
    Added working zoom buttons in planVisualizer.html
    
    Added zoom buttons to hole webclient

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Improved WebClient

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/82#issuecomment-50500138
  
    We decided on a feature freeze a while back. This will go into the next version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Improved WebClient

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/82


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Improved WebClient

Posted by JonathanH5 <gi...@git.apache.org>.

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/82#issuecomment-50509106
  
    ok, I am fine with everything ... . So I will continue to integrate more improvements ... . 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Improved WebClient

Posted by JonathanH5 <gi...@git.apache.org>.

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/82#issuecomment-50474736
  
    @StephanEwen, @rmetzger : this should be merged before the release because it improves the webclient a lot.
    
    The zoom feature is not perfect, because it pans the view a little bit to the left. I was not able to fix this, but it is better than no zooming without a mouse (i spend quit a lot of time on this :/) ... . The old zoom functionality is still working.
    
    Related issues from JIRA (may be incomplete): 
    https://issues.apache.org/jira/browse/FLINK-954


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---