You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/02/10 19:58:42 UTC
Review Request 56558: Control Log Level for all Hive components for
log4j
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-19968
https://issues.apache.org/jira/browse/AMBARI-19968
Repository: ambari
Description
-------
Control Log Level for all Hive components for log4j
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java d92c04d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py a2879da
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py b4e4a03
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 928bf06
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml efe9d6e
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml 14e58bd
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 3b935f8
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml 01d556f
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml ff93265
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml bc0c7de
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 9caf51e
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py e942201
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dde7933
Diff: https://reviews.apache.org/r/56558/diff/
Testing
-------
Check UI if new drop down is visible
Change value and check from API, disk if the loglevels change for the hive-log4j files
Enable Hive-interactive and check if the changes are seen in hive log4j2 files
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 56558: Control Log Level for all Hive components
for log4j
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/#review165211
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml (line 112)
<https://reviews.apache.org/r/56558/#comment237029>
Can we set these to false as well? For all the three additions.
- Sumit Mohanty
On Feb. 10, 2017, 10:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56558/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19968
> https://issues.apache.org/jira/browse/AMBARI-19968
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Control Log Level for all Hive components for log4j
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java d92c04d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py a2879da
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py b4e4a03
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 928bf06
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml efe9d6e
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml 14e58bd
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 3b935f8
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml 01d556f
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml ff93265
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml bc0c7de
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 9caf51e
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py e942201
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dde7933
>
> Diff: https://reviews.apache.org/r/56558/diff/
>
>
> Testing
> -------
>
> Check UI if new drop down is visible
> Change value and check from API, disk if the loglevels change for the hive-log4j files
> Enable Hive-interactive and check if the changes are seen in hive log4j2 files
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 56558: Control Log Level for all Hive components
for log4j
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/#review165223
-----------------------------------------------------------
Ship it!
Based on https://issues.apache.org/jira/secure/attachment/12852169/AMBARI-19968.patch
- Sumit Mohanty
On Feb. 10, 2017, 10:04 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56558/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 10:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-19968
> https://issues.apache.org/jira/browse/AMBARI-19968
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Control Log Level for all Hive components for log4j
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java d92c04d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py a2879da
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py b4e4a03
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 928bf06
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml efe9d6e
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml 14e58bd
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 3b935f8
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml 01d556f
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml ff93265
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml bc0c7de
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 9caf51e
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py e942201
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0
> ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dde7933
>
> Diff: https://reviews.apache.org/r/56558/diff/
>
>
> Testing
> -------
>
> Check UI if new drop down is visible
> Change value and check from API, disk if the loglevels change for the hive-log4j files
> Enable Hive-interactive and check if the changes are seen in hive log4j2 files
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 56558: Control Log Level for all Hive components
for log4j
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56558/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 10:04 p.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-19968
https://issues.apache.org/jira/browse/AMBARI-19968
Repository: ambari
Description
-------
Control Log Level for all Hive components for log4j
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/theme/TabLayout.java d92c04d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py a2879da
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py b4e4a03
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 928bf06
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/beeline-log4j2.xml efe9d6e
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-env.xml 14e58bd
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-exec-log4j2.xml 3b935f8
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-log4j2.xml 01d556f
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-cli-log4j2.xml ff93265
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml bc0c7de
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/webhcat-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 9caf51e
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py d102b9d
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py e942201
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ec3e8f0
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dde7933
Diff: https://reviews.apache.org/r/56558/diff/
Testing
-------
Check UI if new drop down is visible
Change value and check from API, disk if the loglevels change for the hive-log4j files
Enable Hive-interactive and check if the changes are seen in hive log4j2 files
Thanks,
Madhuvanthi Radhakrishnan