You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/17 05:32:24 UTC

[GitHub] [superset] thomasdesr commented on a change in pull request #18690: fix: Update time grain expressions for Spark >= 3.x

thomasdesr commented on a change in pull request #18690:
URL: https://github.com/apache/superset/pull/18690#discussion_r808688491



##########
File path: superset/db_engine_specs/databricks.py
##########
@@ -37,7 +51,7 @@ class DatabricksODBCEngineSpec(BaseEngineSpec):
     # the syntax for the ODBC engine is identical to the Hive one, so
     # we can reuse the expressions from `HiveEngineSpec`
     # pylint: disable=protected-access
-    _time_grain_expressions = HiveEngineSpec._time_grain_expressions
+    _time_grain_expressions = DatabricksHiveEngineSpec._time_grain_expressions

Review comment:
       Sounds good here! :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org