You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nlpcraft.apache.org by GitBox <gi...@apache.org> on 2021/07/09 16:44:13 UTC

[GitHub] [incubator-nlpcraft] skhdl commented on pull request #15: Nlpcraft 339 - Added test for PhoneModel example

skhdl commented on pull request #15:
URL: https://github.com/apache/incubator-nlpcraft/pull/15#issuecomment-877316822


   hi!
   I have few comments
   1) Look at weather_example pom.xml. 
   Similar should be for `phone` example pom.xml
    - junit should be added to pom.xml
    - test should be excluded on verify phase.
   2) Short memo should be added for this test
    - change config for server  (tokenProviders = “nlpcraft,google”)
    - set GOOGLE_APPLICATION_CREDENTIALS
   3) this test is special case. We have to disable it by default (Look at junit `disable` annotations). 
   This tests should be started manually only (developer should enable it and follow the memo)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nlpcraft.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org