You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/06/30 05:39:53 UTC

[GitHub] [incubator-ratis] cyrus-jackson opened a new pull request #140: Adds new JMX metric for getting Groups a server is part of

cyrus-jackson opened a new pull request #140:
URL: https://github.com/apache/incubator-ratis/pull/140


   ## What changes were proposed in this pull request?
   
   This PR added a new jmx metric to show the Groups a server is part of.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/projects/RATIS/issues/RATIS-965
   
   ## How was this patch tested?
   
   Manual test. I have tested this using Java Mission Control to check weather metrics are properly emitting or not. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] lokeshj1703 closed pull request #140: RATIS-965. Adds new JMX metric for getting Groups a server is part of

Posted by GitBox <gi...@apache.org>.
lokeshj1703 closed pull request #140:
URL: https://github.com/apache/incubator-ratis/pull/140


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] cyrus-jackson commented on pull request #140: Adds new JMX metric for getting Groups a server is part of

Posted by GitBox <gi...@apache.org>.
cyrus-jackson commented on pull request #140:
URL: https://github.com/apache/incubator-ratis/pull/140#issuecomment-653775524


   @lokeshj1703 Can you please review the patch. Thanks in advance.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] lokeshj1703 commented on pull request #140: RATIS-965. Adds new JMX metric for getting Groups a server is part of

Posted by GitBox <gi...@apache.org>.
lokeshj1703 commented on pull request #140:
URL: https://github.com/apache/incubator-ratis/pull/140#issuecomment-666206013


   @cyrus-jackson Thanks for the contribution! I have committed the PR to master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #140: Adds new JMX metric for getting Groups a server is part of

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #140:
URL: https://github.com/apache/incubator-ratis/pull/140#issuecomment-651694904


   @cyrus-jackson Hi, You can push an empty commit by `git commit --allow-empty -m "triger ci"` to trigger CI again. The CI passed ratio is about 50%.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] cyrus-jackson commented on pull request #140: Adds new JMX metric for getting Groups a server is part of

Posted by GitBox <gi...@apache.org>.
cyrus-jackson commented on pull request #140:
URL: https://github.com/apache/incubator-ratis/pull/140#issuecomment-651693429


   Failing tests are not related to the patch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org