[GitHub] [carbondata] jackylk commented on a change in pull request #3529: [CARBONDATA-3628] Support alter hive table add complex column type

[GitBox <gi...@apache.org>]

jackylk commented on a change in pull request #3529: [CARBONDATA-3628] Support alter hive table add complex column type
URL: https://github.com/apache/carbondata/pull/3529#discussion_r361096161
 
 

 ##########
 File path: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/AlterTableTestCase.scala
 ##########
 @@ -1023,6 +1023,7 @@ class AlterTableTestCase extends QueryTest with BeforeAndAfterAll {
     } else if (SparkUtil.isSparkVersionXandAbove("2.2")) {
       sql("alter table alter_hive add columns(add string)")
       sql("insert into alter_hive select 'abc','banglore'")
+      sql("alter table alter_hive add columns (var map<string, string>)")
 
 Review comment:
   Thanks for contribution.
   Can you add a testcase to load data after adding the complex column?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services