You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2015/11/30 06:22:14 UTC

svn commit: r1717179 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java

Author: onealj
Date: Mon Nov 30 05:22:14 2015
New Revision: 1717179

URL: http://svn.apache.org/viewvc?rev=1717179&view=rev
Log:
add @Override annotation. Explicitly specify workbook type returned by SXSSFITestDataProvider.writeOutAndReadBack

Modified:
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java?rev=1717179&r1=1717178&r2=1717179&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java Mon Nov 30 05:22:14 2015
@@ -46,6 +46,7 @@ public final class SXSSFITestDataProvide
         // enforce singleton
     }
 
+    @Override
     public Workbook openSampleWorkbook(String sampleFileName) {
         XSSFWorkbook xssfWorkbook = XSSFITestDataProvider.instance.openSampleWorkbook(sampleFileName);
         SXSSFWorkbook swb = new SXSSFWorkbook(xssfWorkbook);
@@ -53,12 +54,16 @@ public final class SXSSFITestDataProvide
         return swb;
     }
 
-    public Workbook writeOutAndReadBack(Workbook wb) {
+    /**
+     * Returns an XSSFWorkbook since SXSSFWorkbook is write-only
+     */
+    @Override
+    public XSSFWorkbook writeOutAndReadBack(Workbook wb) {
         if(!(wb instanceof SXSSFWorkbook)) {
             throw new IllegalArgumentException("Expected an instance of SXSSFWorkbook");
         }
 
-        Workbook result;
+        XSSFWorkbook result;
         try {
             ByteArrayOutputStream baos = new ByteArrayOutputStream(8192);
             wb.write(baos);
@@ -70,24 +75,29 @@ public final class SXSSFITestDataProvide
         return result;
     }
 
+    @Override
     public SXSSFWorkbook createWorkbook(){
         SXSSFWorkbook wb = new SXSSFWorkbook();
         instances.add(wb);
         return wb;
     }
     
+    @Override
     public FormulaEvaluator createFormulaEvaluator(Workbook wb) {
         return new XSSFFormulaEvaluator(((SXSSFWorkbook) wb).getXSSFWorkbook());
     }
 
+    @Override
     public byte[] getTestDataFileContent(String fileName) {
         return POIDataSamples.getSpreadSheetInstance().readFile(fileName);
     }
 
+    @Override
     public SpreadsheetVersion getSpreadsheetVersion(){
         return SpreadsheetVersion.EXCEL2007;
     }
 
+    @Override
     public String getStandardFileNameExtension() {
         return "xlsx";
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org