You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/03 19:50:10 UTC
[GitHub] [solr] epugh opened a new pull request, #930: SOLR-16281: review boxing unboxing
epugh opened a new pull request, #930:
URL: https://github.com/apache/solr/pull/930
https://issues.apache.org/jira/browse/SOLR-16281
# Description
boxing/unboxing has been improved since Java 5!
# Solution
Apply suggestiosn!
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #930: SOLR-16281: review boxing unboxing
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #930:
URL: https://github.com/apache/solr/pull/930#discussion_r913181003
##########
solr/core/src/test/org/apache/solr/handler/component/TestPivotHelperCode.java:
##########
@@ -89,8 +89,7 @@ public void testCompareWithNullLast() {
assertEquals(a.compareTo(b), PivotFacetFieldValueCollection.compareWithNullLast(a, b));
assertEquals(b.compareTo(a), PivotFacetFieldValueCollection.compareWithNullLast(b, a));
- Long bb = new Long(b.longValue());
- assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, bb));
+ assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, b));
Review Comment:
you know what, I'll just roll this cahnge back ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #930: SOLR-16281: review boxing unboxing
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #930:
URL: https://github.com/apache/solr/pull/930#discussion_r913162412
##########
solr/core/src/test/org/apache/solr/handler/component/TestPivotHelperCode.java:
##########
@@ -89,8 +89,7 @@ public void testCompareWithNullLast() {
assertEquals(a.compareTo(b), PivotFacetFieldValueCollection.compareWithNullLast(a, b));
assertEquals(b.compareTo(a), PivotFacetFieldValueCollection.compareWithNullLast(b, a));
- Long bb = new Long(b.longValue());
- assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, bb));
+ assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, b));
Review Comment:
hmm, not sure about this one, looks like it's part of the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #930: SOLR-16281: review boxing unboxing
Posted by GitBox <gi...@apache.org>.
epugh merged PR #930:
URL: https://github.com/apache/solr/pull/930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #930: SOLR-16281: review boxing unboxing
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #930:
URL: https://github.com/apache/solr/pull/930#discussion_r913180601
##########
solr/core/src/test/org/apache/solr/handler/component/TestPivotHelperCode.java:
##########
@@ -89,8 +89,7 @@ public void testCompareWithNullLast() {
assertEquals(a.compareTo(b), PivotFacetFieldValueCollection.compareWithNullLast(a, b));
assertEquals(b.compareTo(a), PivotFacetFieldValueCollection.compareWithNullLast(b, a));
- Long bb = new Long(b.longValue());
- assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, bb));
+ assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, b));
Review Comment:
As I edited it, I wondered if you were going to call this one out! Eagle Eyes! I could totally be swayed to undo it. The line `Long bb = new Long(b.longValue()); ` means we are basically testing Java functionality???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #930: SOLR-16281: review boxing unboxing
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #930:
URL: https://github.com/apache/solr/pull/930#issuecomment-1174042387
Do you think this is ready now for merging @cpoerschke ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org