You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2024/06/06 14:48:26 UTC
[PR] [jvm] test [doris]
morningman opened a new pull request, #36001:
URL: https://github.com/apache/doris/pull/36001
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [jvm] test [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #36001:
URL: https://github.com/apache/doris/pull/36001#discussion_r1629705272
##########
be/src/util/jvm_metrics.cpp:
##########
@@ -182,31 +186,30 @@ void JvmMetrics::update() {
}
}
-void JvmStats::init(JNIEnv* ENV) {
+Status JvmStats::init(JNIEnv* ENV) {
Review Comment:
warning: function 'init' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status JvmStats::init(JNIEnv* ENV) {
^
```
<details>
<summary>Additional context</summary>
**be/src/util/jvm_metrics.cpp:188:** 140 lines including whitespace and comments (threshold 80)
```cpp
Status JvmStats::init(JNIEnv* ENV) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [jvm] test [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #36001:
URL: https://github.com/apache/doris/pull/36001#issuecomment-2152731994
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [jvm] test [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36001:
URL: https://github.com/apache/doris/pull/36001#issuecomment-2152731947
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [jvm] test [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman closed pull request #36001: [jvm] test
URL: https://github.com/apache/doris/pull/36001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org