You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/19 21:55:08 UTC
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2870: Support for ESP32-C3 GPIO Driver
Ouss4 edited a comment on pull request #2870:
URL: https://github.com/apache/incubator-nuttx/pull/2870#issuecomment-782385127
> My intention is to avoid layout out code which promotes copying as it is difficult to remain vigilant about duplicated code in subsquent PRs. I feel it is better to avoid it altogether from the start.
Yes, I understand and agree with your point.
I think, however, that our discussion has drifted a little bit from the purpose of this PR, we will definitely come back to the board's organisation in the upcoming days when we have more drivers supported. However, as mentioned, the gpio board logic will either stay specific to each board or need some changes to make it a bit more generic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org