You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/06/11 08:24:33 UTC
[kudu-CR] [docs] Add 'CLI tools to access a cluster via cluster name' section
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13579
Change subject: [docs] Add 'CLI tools to access a cluster via cluster name' section
......................................................................
[docs] Add 'CLI tools to access a cluster via cluster name' section
Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
---
M docs/administration.adoc
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/13579/1
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
Patch Set 2:
> Patch Set 1:
>
> (5 comments)
>
> Thanks for doing this.
>
> When submitting docs changes, we typically also push them to our own personal forks of Kudu on GitHub so that the contents of the AsciiDoc files are rendered for reviewers.
>
> For example, here's a patch I wrote not too long ago to contributing.adoc: https://github.com/adembo/kudu/blob/docs/docs/contributing.adoc
You can review it here: https://github.com/acelyc111/kudu/blob/admin_doc/docs/administration.adoc
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 09:26:50 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13579/2/docs/administration.adoc
File docs/administration.adoc:
PS2:
> Looks like the new patch added some extra newlines to the end of some lines
Done
http://gerrit.cloudera.org:8080/#/c/13579/2/docs/administration.adoc@1454
PS2, Line 1454: `KUDU_CONFI
> Let's emphasize this word with backticks.
Done
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 02:35:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add 'CLI tools to access a cluster via cluster name' section
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add 'CLI tools to access a cluster via cluster name' section
......................................................................
Patch Set 1:
(5 comments)
Thanks for doing this.
When submitting docs changes, we typically also push them to our own personal forks of Kudu on GitHub so that the contents of the AsciiDoc files are rendered for reviewers.
For example, here's a patch I wrote not too long ago to contributing.adoc: https://github.com/adembo/kudu/blob/docs/docs/contributing.adoc
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1446
PS1, Line 1446: === CLI tools to access a cluster via cluster name
How about: Using cluster names in the `kudu` command line tool
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1448
PS1, Line 1448: Kudu master rpc addresses are not easy to remember when use CLI tools, even
: worse, when manage several Kudu clusters. It's able to use CLI tools to access
: a Kudu cluster via cluster name alternatively.
Rewrite as: When using the `kudu` command line tool, it can be difficult to remember the precise list of Kudu master RPC addresses needed to communicate with a cluster, especially when managing multiple clusters. As an alternative, the command line tool can identify clusters by name. To use this functionality:
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1452
PS1, Line 1452: . Make a Kudu configuration file directory, add an environment variable
: KUDU_CONFIG to this directoty.
: . Add a new YAML format configuration file in this directoty, its content is like:
Rewrite:
- Create a new directory to store the Kudu configuration file.
- Export the path to this directory in the KUDU_CONFIG environment variable.
- Create a file called `kudurc` in the new directory.
- Populate `kudurc` as follows, substituting your own cluster names and RPC addresses:
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1464
PS1, Line 1464: . Use CLI tools to access Kudu cluster via cluster name configured in the file above,
: starting with an extra character `@`, for the `master_addresses` section.
Rewrite: "When using the `kudu` command line tool, replace the list of Kudu master RPC addresses with the cluster name, prepended with the character `@`".
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1475
PS1, Line 1475: NOTE: All CLI tools with a `master_addresses` section can be replaced by a cluster name.
Rewrite: "NOTE: Cluster names may be used as input in any invocation of the `kudu` command line tool that expects a list of Kudu master RPC addresses".
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:11:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13579
to look at the new patch set (#3).
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
[docs] Add docs for CLI cluster name resolver
Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
---
M docs/administration.adoc
1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/13579/3
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1446
PS1, Line 1446: === CLI tools to access a cluster via cluster name
> How about: Using cluster names in the `kudu` command line tool
Done
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1448
PS1, Line 1448: Kudu master rpc addresses are not easy to remember when use CLI tools, even
: worse, when manage several Kudu clusters. It's able to use CLI tools to access
: a Kudu cluster via cluster name alternatively.
> Rewrite as: When using the `kudu` command line tool, it can be difficult to
Done
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1452
PS1, Line 1452: . Make a Kudu configuration file directory, add an environment variable
: KUDU_CONFIG to this directoty.
: . Add a new YAML format configuration file in this directoty, its content is like:
> Rewrite:
Done
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1464
PS1, Line 1464: . Use CLI tools to access Kudu cluster via cluster name configured in the file above,
: starting with an extra character `@`, for the `master_addresses` section.
> Rewrite: "When using the `kudu` command line tool, replace the list of Kudu
Done
http://gerrit.cloudera.org:8080/#/c/13579/1/docs/administration.adoc@1475
PS1, Line 1475: NOTE: All CLI tools with a `master_addresses` section can be replaced by a cluster name.
> Rewrite: "NOTE: Cluster names may be used as input in any invocation of the
Done
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 09:24:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
[docs] Add docs for CLI cluster name resolver
Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Reviewed-on: http://gerrit.cloudera.org:8080/13579
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M docs/administration.adoc
1 file changed, 36 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
Patch Set 3: Verified+1 Code-Review+2
Docs change.
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 03:40:14 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13579 )
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13579/2/docs/administration.adoc
File docs/administration.adoc:
PS2:
Looks like the new patch added some extra newlines to the end of some lines. Could you trim them?
http://gerrit.cloudera.org:8080/#/c/13579/2/docs/administration.adoc@1454
PS2, Line 1454: KUDU_CONFIG
Let's emphasize this word with backticks.
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 19:31:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for CLI cluster name resolver
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13579
to look at the new patch set (#2).
Change subject: [docs] Add docs for CLI cluster name resolver
......................................................................
[docs] Add docs for CLI cluster name resolver
Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
---
M docs/administration.adoc
1 file changed, 36 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/13579/2
--
To view, visit http://gerrit.cloudera.org:8080/13579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib94a44b76008bc9d24e428000205e7c90e3ae653
Gerrit-Change-Number: 13579
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>