You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "viola.lu (JIRA)" <ji...@apache.org> on 2012/07/05 12:17:34 UTC
[jira] [Created] (GERONIMO-6370) Update static files without bundle
restart
viola.lu created GERONIMO-6370:
----------------------------------
Summary: Update static files without bundle restart
Key: GERONIMO-6370
URL: https://issues.apache.org/jira/browse/GERONIMO-6370
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: Aries
Affects Versions: 3.0
Reporter: viola.lu
Assignee: viola.lu
Fix For: 3.0.1
https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411228#comment-13411228 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
There are two things I'm still wondering about:
1. Since now we unpack all the bundles, what do we do for WABs? Will/could/should they be unpacked in 2 places?
2. For better GEP integration we might need something like ApplicationGBean.getPublishLocation() call which would return the disk location of a given bundle. GEP would use this location to publish the modified files to. If bundles are not unpacked then this function would return null. This should address issue #4.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "viola.lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431586#comment-13431586 ]
viola.lu commented on GERONIMO-6370:
------------------------------------
commit changes @ r1371029 and r1371042
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411632#comment-13411632 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
In revision 1360229 I added support for a switch (org.apache.geronimo.aries.unpackApplicationBundles=[true|false]) to control whether the EBA bundles get unpacked or not. Right now, I left the defaults as "true" - unpack.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "viola.lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425667#comment-13425667 ]
viola.lu commented on GERONIMO-6370:
------------------------------------
After expanding folder,
URL convertedURL = FrameworkUtils.convertURL(url); will convert bundleentry:// URL to file:// not jar:/file/, which will result in jsp recompilation, have to update foundIndirectory to make it work against file also.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413159#comment-13413159 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
In revision 1360908 I added two additional functions to EBADeploymentManager that will make GEP operations a bit easy:
1. getEBAContentBundlePublishLocation() returns a directory location of the unpacked bundle. GEP will use this directory to publish the file updates. The function returns non-null value only if the bundle is unpacked into a directory.
2. getEBAContentBundleId() returns a bundle id given a bundle symbolic name and version. This is just to optimize GEP operation when trying to get bundle id for a module in Eclipse.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "viola.lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407655#comment-13407655 ]
viola.lu commented on GERONIMO-6370:
------------------------------------
commit first changes at http://svn.apache.org/viewvc?rev=1357538&view=rev, extract bundles in eba and install it via reference:file, have to check whether this will affect hotswap
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466399#comment-13466399 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
In revision 1391947 I changed the code so that application bundles are unpacked at repository install time. That avoids expensive copying of the unpacked bundle contents to the location under the $GERONIMO_HOME/repository/ directory.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413926#comment-13413926 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
In revision 1361316 committed additional changes to ApplicationUpdateHelper.java to deal better when the entire unpacked bundle gets updated and made more efficient the replacement of an unpacked bundle.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411212#comment-13411212 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
In revision 1360003 I updated ApplicationUpdateHelper.java so that it can additionally deal with unpacked ebas with unpacked bundles.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "viola.lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411350#comment-13411350 ]
viola.lu commented on GERONIMO-6370:
------------------------------------
#1. Now in GEP, it replaces wab static files unpacked in $install_home/var/catalina/[doc_base]/, this is different from wab directory unpacked in EBA with wab filename as directory not doc_base.
#2. Now we installed eba with reference:file not file:/
bundleInfo.add(new SimpleBundleInfo(applicationFactory, bm, "reference:" + file.toURI().toString()));
If GEP supports packaged bundle static files update, there will be lock issue, otherwise we install bundles in cache not reference.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410933#comment-13410933 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
I realized the suggestion #1 won't work. I just updated the code a bit (in revision 1359909) so that it can support both unpacked and packed bundles in ebas. I also took care of #2.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411916#comment-13411916 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
Viola,
1) The name of directory doesn't matter that much. What matters is that the contents for a WAB will be unpacked in two places. One under repository/ and another one under var/catalina/. We need to avoid that.
2) My changes in revision 1360229 avoid the locking issue by handling jar files and directories differently.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411976#comment-13411976 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
Looks like our Tomcat code already handles directories correctly so the WAB is not extracted twice and it sets the right document base location so GEP knows where to publish the modified files. Sweet!
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GERONIMO-6370) Update static files without
bundle restart
Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410742#comment-13410742 ]
Jarek Gawor commented on GERONIMO-6370:
---------------------------------------
I was reviewing your changes and I have a few comments:
1) The changes to ApplicationInstaller.java in revision 1357538 should be unnecessary if we just add the following to AbstractRepository.java:
typeHandlers.put("eba", new UnpackArtifactTypeHandler());
This I believe will work much nicer (and easy to undo in case there is a problem).
2) In the same revision I'm not sure why unpackBundleFile() function was added to GeronimoApplication.java
3) Please fix your editor to use 4 spaces instead of tabs and format your code. It is hard to read it otherwise.
4) Changes made in revision 1357550 to GEP assume now that the bundle file is unpacked. GEP should be smart enough to work with unpacked or packed bundle files.
> Update static files without bundle restart
> ------------------------------------------
>
> Key: GERONIMO-6370
> URL: https://issues.apache.org/jira/browse/GERONIMO-6370
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Aries
> Affects Versions: 3.0
> Reporter: viola.lu
> Assignee: viola.lu
> Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira