You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2015/01/08 20:44:54 UTC

[GitHub] spark pull request: [SPARK-1405][MLLIB] LDA on GraphX

Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/2388#issuecomment-69236818
  
    @witgo  I’m submitting a simple PR for LDA which using EM for learning.  I believe that it would be good to support other learning methods such as Gibbs sampling (as in your PR), where the user can select the learning method via an LDA parameter.  If you have feedback on my PR, especially the public API, please do let me know.  Thanks very much!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org