You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/01 03:05:11 UTC

[GitHub] [incubator-nuttx] zyfeier opened a new pull request, #7493: clock: adjust clock function to support tick

zyfeier opened a new pull request, #7493:
URL: https://github.com/apache/incubator-nuttx/pull/7493

   ## Summary
   
   When CONFIG_SCHED_TICKLESS_TICK_ARGUMENT enabled, we can use up_timer_gettick to get ticks for better performance.
   
   ## Impact
   
   N/A
   
   ## Testing
   
   IMX6Q sabre-6quad:nsh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7493: clock: adjust clock function to support tick

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7493:
URL: https://github.com/apache/incubator-nuttx/pull/7493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7493: clock: adjust clock function to support tick

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7493:
URL: https://github.com/apache/incubator-nuttx/pull/7493#discussion_r1010037825


##########
sched/clock/clock_systime_timespec.c:
##########
@@ -109,84 +109,25 @@ int clock_systime_timespec(FAR struct timespec *ts)
   else
 #endif
     {
-#if defined(CONFIG_SCHED_TICKLESS)
       /* In tickless mode, all timing is controlled by platform-specific
        * code.  Let the platform timer do the work.
        */
 
-#ifdef CONFIG_SCHED_TICKLESS_TICK_ARGUMENT
+#if defined(CONFIG_SCHED_TICKLESS_TICK_ARGUMENT)
       clock_t ticks;
       int ret;
 
       ret = up_timer_gettick(&ticks);
       timespec_from_tick(ts, ticks);
       return ret;
-#else
+#elif defined (CONFIG_SCHED_TICKLESS)

Review Comment:
   ```suggestion
   #elif defined(CONFIG_SCHED_TICKLESS)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org