You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by "Mike Beckerle (Jira)" <ji...@apache.org> on 2021/07/21 18:32:00 UTC

[jira] [Commented] (DAFFODIL-2547) Sort project dependencies

    [ https://issues.apache.org/jira/browse/DAFFODIL-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17385049#comment-17385049 ] 

Mike Beckerle commented on DAFFODIL-2547:
-----------------------------------------

Test dependencies need to end up on the class path earlier sometimes than other things. Think mokito mocks that have to be found instead of the things they are mocking. 

So I suggest test dependencies should go first, so they end up earlier on the class path. 

Alphabetical is otherwise good, except when the order matters. It can matter if one jar redefines something in another jar.  I don't know that we have any such ordering constraints for Daffodil's dependencies, but it's something that it is possible to depend on. 

Any such ordering-dependencies should have specific comments. Otherwise someone fixing out-of-alphabetical-order things could break the overrides. 

> Sort project dependencies
> -------------------------
>
>                 Key: DAFFODIL-2547
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2547
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Steve Lawrence
>            Priority: Trivial
>
> There's not much rhyme or reason to the order of dependencies in project/Dependencies.scala. To improve readability and consistency, we should sort the individual dependencies. Sort by organization/name makes the most sense. Maybe also group based on test vs compile targets as well?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)