You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/14 09:27:27 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
gaoyunhaii opened a new pull request #16825:
URL: https://github.com/apache/flink/pull/16825
## What is the purpose of the change
This PR fixes the issue that if uidHash is set, when checking finished state consistency the checker only retrieve state with the uidHash, but if the checkpoint is taking after the job started, the state would be keyed with the generated id.
## Brief change log
- da755cb1681130e773f6b57fb925f85854d159d7 fixes the issue by only retrieve the state with uidHash if uidHash is configured and there are state keyed with it.
## Verifying this change
This change is verified with the added UT.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **yes**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da755cb1681130e773f6b57fb925f85854d159d7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
}, {
"hash" : "53de40a607ecee7d0e011980c21907ed19433a46",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549",
"triggerID" : "53de40a607ecee7d0e011980c21907ed19433a46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da755cb1681130e773f6b57fb925f85854d159d7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181)
* 53de40a607ecee7d0e011980c21907ed19433a46 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898871101
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit da755cb1681130e773f6b57fb925f85854d159d7 (Sat Aug 14 09:31:13 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-23770).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
}, {
"hash" : "53de40a607ecee7d0e011980c21907ed19433a46",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549",
"triggerID" : "53de40a607ecee7d0e011980c21907ed19433a46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53de40a607ecee7d0e011980c21907ed19433a46 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da755cb1681130e773f6b57fb925f85854d159d7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-904406773
LGTM! Thanks @gaoyunhaii for fixing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
}, {
"hash" : "53de40a607ecee7d0e011980c21907ed19433a46",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "53de40a607ecee7d0e011980c21907ed19433a46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da755cb1681130e773f6b57fb925f85854d159d7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181)
* 53de40a607ecee7d0e011980c21907ed19433a46 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #16825:
URL: https://github.com/apache/flink/pull/16825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-904762929
Very thanks Yuan @curcur for the review! I'll merge the code~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
}, {
"hash" : "53de40a607ecee7d0e011980c21907ed19433a46",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549",
"triggerID" : "53de40a607ecee7d0e011980c21907ed19433a46",
"triggerType" : "PUSH"
}, {
"hash" : "3934fc5ceb5264034908efb61123dc2b75ad9d51",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22720",
"triggerID" : "3934fc5ceb5264034908efb61123dc2b75ad9d51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53de40a607ecee7d0e011980c21907ed19433a46 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549)
* 3934fc5ceb5264034908efb61123dc2b75ad9d51 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22720)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a change in pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
curcur commented on a change in pull request #16825:
URL: https://github.com/apache/flink/pull/16825#discussion_r694585208
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorRestoringTest.java
##########
@@ -1208,10 +1208,24 @@ public void testRestoreLatestCheckpointedStateWithoutInFlightData() throws Excep
}
@Test
- public void testRestoringPartiallyFinishedChainsFails() throws Exception {
+ public void testRestoringPartiallyFinishedChainsFailsWithoutUidHash() throws Exception {
+ // If useUidHash is set to false, the operator states would still be keyed with the
+ // generated ID, which simulates the case of restoring a checkpoint taking after jobs
Review comment:
taking -> taken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
}, {
"hash" : "53de40a607ecee7d0e011980c21907ed19433a46",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549",
"triggerID" : "53de40a607ecee7d0e011980c21907ed19433a46",
"triggerType" : "PUSH"
}, {
"hash" : "3934fc5ceb5264034908efb61123dc2b75ad9d51",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3934fc5ceb5264034908efb61123dc2b75ad9d51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53de40a607ecee7d0e011980c21907ed19433a46 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549)
* 3934fc5ceb5264034908efb61123dc2b75ad9d51 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da755cb1681130e773f6b57fb925f85854d159d7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16825: [FLINK-23770][runtime][checkpoint] Retrieve the state with both uidHash and generated ID on checking finished state consistency
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16825:
URL: https://github.com/apache/flink/pull/16825#issuecomment-898872020
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da755cb1681130e773f6b57fb925f85854d159d7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22181",
"triggerID" : "da755cb1681130e773f6b57fb925f85854d159d7",
"triggerType" : "PUSH"
}, {
"hash" : "53de40a607ecee7d0e011980c21907ed19433a46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22549",
"triggerID" : "53de40a607ecee7d0e011980c21907ed19433a46",
"triggerType" : "PUSH"
}, {
"hash" : "3934fc5ceb5264034908efb61123dc2b75ad9d51",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22720",
"triggerID" : "3934fc5ceb5264034908efb61123dc2b75ad9d51",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3934fc5ceb5264034908efb61123dc2b75ad9d51 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22720)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org