You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2024/12/06 16:00:47 UTC
[PR] AIP-84 Filter task instances list by task id and display name [airflow]
jason810496 opened a new pull request, #44736:
URL: https://github.com/apache/airflow/pull/44736
closes: #44670
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Filter task instances list by task id and display name [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #44736:
URL: https://github.com/apache/airflow/pull/44736#issuecomment-2528666042
Just resolve, move `QueryTaskDisplayNamePatternSearch` to common paramters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Filter task instances list by task id and display name [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #44736:
URL: https://github.com/apache/airflow/pull/44736#discussion_r1876282431
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -112,7 +112,7 @@ def depends(self, only_active: bool = True) -> _OnlyActiveFilter:
return self.set_value(only_active)
-class _SearchParam(BaseParam[str]):
+class SearchParam(BaseParam[str]):
Review Comment:
If then, I will move the it to common parameter. Thanks for catching @bbovenzi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Filter task instances list by task id and display name [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #44736:
URL: https://github.com/apache/airflow/pull/44736#discussion_r1876275150
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -112,7 +112,7 @@ def depends(self, only_active: bool = True) -> _OnlyActiveFilter:
return self.set_value(only_active)
-class _SearchParam(BaseParam[str]):
+class SearchParam(BaseParam[str]):
Review Comment:
I could see us using `task_display_name_pattern` in other endpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Filter task instances list by task id and display name [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #44736:
URL: https://github.com/apache/airflow/pull/44736#discussion_r1875861775
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -112,7 +112,7 @@ def depends(self, only_active: bool = True) -> _OnlyActiveFilter:
return self.set_value(only_active)
-class _SearchParam(BaseParam[str]):
+class SearchParam(BaseParam[str]):
Review Comment:
Hi @shubhamraj-git,
From my perspective, I think `task_display_name_pattern` is not currently used by other endpoints, so it might not be suitable to place it in common parameters. WDYT ?
Here some related discussion https://github.com/apache/airflow/pull/43947#issuecomment-2503874473 about common parameters.
Additionally, some `_SearchParam` constructs in common parameters should be refactored out ( since those only be used in one endpoint ). It seems I overlooked this in https://github.com/apache/airflow/pull/43947 PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Filter task instances list by task id and display name [airflow]
Posted by "shubhamraj-git (via GitHub)" <gi...@apache.org>.
shubhamraj-git commented on code in PR #44736:
URL: https://github.com/apache/airflow/pull/44736#discussion_r1874886883
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -112,7 +112,7 @@ def depends(self, only_active: bool = True) -> _OnlyActiveFilter:
return self.set_value(only_active)
-class _SearchParam(BaseParam[str]):
+class SearchParam(BaseParam[str]):
Review Comment:
Can we let it be a internal class and instead using directly in task_instances.py,
we can define a query variable under parameters?
`QueryTaskDisplayNamePatternSearch`
I think we follow the similar for other searches too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AIP-84 Filter task instances list by task id and display name [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #44736:
URL: https://github.com/apache/airflow/pull/44736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org