You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/29 11:23:36 UTC

[GitHub] [spark] zhengruifeng commented on a change in pull request #25286: [SPARK-25584][ML][DOC] datasource for libsvm user guide

zhengruifeng commented on a change in pull request #25286: [SPARK-25584][ML][DOC] datasource for libsvm user guide
URL: https://github.com/apache/spark/pull/25286#discussion_r308179073
 
 

 ##########
 File path: docs/_data/menu-ml.yaml
 ##########
 @@ -1,7 +1,7 @@
 - text: Basic statistics
   url: ml-statistics.html
 - text: Data sources
-  url: ml-datasource
+  url: ml-datasource.html
 
 Review comment:
   The orginal `url: ml-datasource` is incorrect that the generated url lose suffix `.html`
   This do not matter in the offical web, since it seems that model web browser will automatically add the suffix.
   However, in the locally built docs, we can not open the ml-datasource link `file:///Users/xxx/Dev/OpenSource/spark/docs/_site/ml-datasource` from page `file:///Users/xxx/Dev/OpenSource/spark/docs/_site/ml-guide.html`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org