[GitHub] marcoabreu commented on a change in pull request #9841: Update versions of python dependencies

[GitBox <gi...@apache.org>]

marcoabreu commented on a change in pull request #9841: Update versions of python dependencies
URL: https://github.com/apache/incubator-mxnet/pull/9841#discussion_r169562797
 
 

 ##########
 File path: python/setup.py
 ##########
 @@ -28,7 +28,7 @@
 else:
     from setuptools import setup
     from setuptools.extension import Extension
-    kwargs = {'install_requires': ['numpy<=1.13.3,>=1.8.2', 'requests==2.18.4', 'graphviz==0.8.1'], 'zip_safe': False}
+    kwargs = {'install_requires': ['numpy<1.15.0,>=1.8.2', 'requests<2.19.0,>=2.18.4', 'graphviz<0.9.0,>=0.8.1'], 'zip_safe': False}
 
 Review comment:
   Shouldn't we pin a specific version rather than specifying a range or is this the best practice in Python?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services