You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2011/08/05 18:03:27 UTC
[jira] [Created] (KAFKA-84) commit offset before consumer shutdown
commit offset before consumer shutdown
--------------------------------------
Key: KAFKA-84
URL: https://issues.apache.org/jira/browse/KAFKA-84
Project: Kafka
Issue Type: Improvement
Components: core
Affects Versions: 0.7
Reporter: Jun Rao
Assignee: Jun Rao
Fix For: 0.7
To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-84) commit offset before consumer
shutdown
Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080069#comment-13080069 ]
Neha Narkhede commented on KAFKA-84:
------------------------------------
Looks good.
+1
> commit offset before consumer shutdown
> --------------------------------------
>
> Key: KAFKA-84
> URL: https://issues.apache.org/jira/browse/KAFKA-84
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.7
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.7
>
> Attachments: kafka-84.patch
>
>
> To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-84) commit offset before consumer
shutdown
Posted by "Jay Kreps (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080081#comment-13080081 ]
Jay Kreps commented on KAFKA-84:
--------------------------------
+1
Nice catch!.
For consistency it would be good if it was commitOffsets() instead of commitOffsets since the convention we (kind of) have is that things with side effects get the method style call and things with no side effects get the variable-access style call.
> commit offset before consumer shutdown
> --------------------------------------
>
> Key: KAFKA-84
> URL: https://issues.apache.org/jira/browse/KAFKA-84
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.7
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.7
>
> Attachments: kafka-84.patch
>
>
> To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-84) commit offset before consumer shutdown
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-84:
-------------------------
Status: Patch Available (was: Open)
patch ready for review.
> commit offset before consumer shutdown
> --------------------------------------
>
> Key: KAFKA-84
> URL: https://issues.apache.org/jira/browse/KAFKA-84
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.7
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.7
>
> Attachments: kafka-84.patch
>
>
> To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-84) commit offset before consumer shutdown
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-84:
-------------------------
Attachment: kafka-84.patch
> commit offset before consumer shutdown
> --------------------------------------
>
> Key: KAFKA-84
> URL: https://issues.apache.org/jira/browse/KAFKA-84
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.7
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.7
>
> Attachments: kafka-84.patch
>
>
> To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-84) commit offset before consumer shutdown
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-84:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> commit offset before consumer shutdown
> --------------------------------------
>
> Key: KAFKA-84
> URL: https://issues.apache.org/jira/browse/KAFKA-84
> Project: Kafka
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.7
> Reporter: Jun Rao
> Assignee: Jun Rao
> Fix For: 0.7
>
> Attachments: kafka-84.patch
>
>
> To avoid duplicated messages, the consumer should do a final offset commit before shutting itself down, if autocommit is enabled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira