You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2013/12/03 02:34:28 UTC
Review Request 15954: Fix cgroup code to use processes rather than threads
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
Repository: mesos-git
Description
-------
the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs" which lists processes.
see https://issues.apache.org/jira/browse/MESOS-859
Diffs
-----
src/linux/cgroups.hpp 6f60c43
src/linux/cgroups.cpp 5a95e75
src/tests/cgroups_tests.cpp bc5f961
Diff: https://reviews.apache.org/r/15954/diff/
Testing
-------
make check # on linux
Thanks,
Ian Downes
Re: Review Request 15954: Fix cgroup code to use processes rather than
threads
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/#review29637
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/15954/#comment57046>
Perhaps a note here about thread group ids and the lack of guarantees:
- cgroup.procs: list of thread group IDs in the cgroup. This list is
not guaranteed to be sorted or free of duplicate TGIDs, and userspace
should sort/uniquify the list if this property is required.
Writing a thread group ID into this file moves all threads in that
group into this cgroup.
- Ben Mahler
On Dec. 3, 2013, 1:34 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15954/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 1:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs" which lists processes.
>
> see https://issues.apache.org/jira/browse/MESOS-859
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 6f60c43
> src/linux/cgroups.cpp 5a95e75
> src/tests/cgroups_tests.cpp bc5f961
>
> Diff: https://reviews.apache.org/r/15954/diff/
>
>
> Testing
> -------
>
> make check # on linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 15954: Fix cgroup code to use processes rather than
threads
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 3, 2013, 10:23 p.m., Ben Mahler wrote:
> > Can you add MESOS-859 to this review?
This is committed, please link MESOS-859 into this review before marking as submitted.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/#review29687
-----------------------------------------------------------
On Dec. 3, 2013, 6:52 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15954/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs" which lists processes.
>
> see https://issues.apache.org/jira/browse/MESOS-859
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 6f60c43
> src/linux/cgroups.cpp 5a95e75
> src/tests/cgroups_tests.cpp bc5f961
>
> Diff: https://reviews.apache.org/r/15954/diff/
>
>
> Testing
> -------
>
> make check # on linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 15954: Fix cgroup code to use processes rather than
threads
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/#review29687
-----------------------------------------------------------
Ship it!
Can you add MESOS-859 to this review?
- Ben Mahler
On Dec. 3, 2013, 6:52 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15954/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs" which lists processes.
>
> see https://issues.apache.org/jira/browse/MESOS-859
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 6f60c43
> src/linux/cgroups.cpp 5a95e75
> src/tests/cgroups_tests.cpp bc5f961
>
> Diff: https://reviews.apache.org/r/15954/diff/
>
>
> Testing
> -------
>
> make check # on linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 15954: Fix cgroup code to use processes rather than
threads
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/#review29683
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Dec. 3, 2013, 6:52 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15954/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs" which lists processes.
>
> see https://issues.apache.org/jira/browse/MESOS-859
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 6f60c43
> src/linux/cgroups.cpp 5a95e75
> src/tests/cgroups_tests.cpp bc5f961
>
> Diff: https://reviews.apache.org/r/15954/diff/
>
>
> Testing
> -------
>
> make check # on linux
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 15954: Fix cgroup code to use processes rather than
threads
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 6:52 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
Changes
-------
Added comments
1. cgroup.procs as suggested by bmahler
2. we parse into a set so the pids returned are unique and sorted.
Repository: mesos-git
Description
-------
the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs" which lists processes.
see https://issues.apache.org/jira/browse/MESOS-859
Diffs (updated)
-----
src/linux/cgroups.hpp 6f60c43
src/linux/cgroups.cpp 5a95e75
src/tests/cgroups_tests.cpp bc5f961
Diff: https://reviews.apache.org/r/15954/diff/
Testing
-------
make check # on linux
Thanks,
Ian Downes