You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/29 15:27:22 UTC
[GitHub] [incubator-shardingsphere] gongsiran opened a new pull request #4533: Add doc to describe read-write split can not support transaction and …
gongsiran opened a new pull request #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533
…explain the reason shortly #4455
Fixes #4455.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4533: Add doc to describe read-write split can not support transaction and …
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4533: Add doc to describe read-write split can not support transaction and …
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533#discussion_r386103573
##########
File path: docs/document/content/features/read-write-split/unsupported-items.cn.md
##########
@@ -7,4 +7,5 @@ weight = 3
1. 主库和从库的数据同步。
1. 主库和从库的数据同步延迟导致的数据不一致。
-1. 主库双写或多写。
\ No newline at end of file
+1. 主库双写或多写。
+1. 跨主库和从库之间的事务的数据不一致。master-slave模型中，事务中读写均用主库。
Review comment:
Can you use Chinese to instead of `master-slave`? `主从` is a better word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4533: Add doc to describe read-write split can not support transaction and …
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533#issuecomment-592958979
## Pull Request Test Coverage Report for [Build 9915](https://coveralls.io/builds/29055584)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.006%**) to **58.144%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29055584/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29055584) |
| :-- | --: |
| Change from base [Build 963](https://coveralls.io/builds/29055302): | -0.006% |
| Covered Lines: | 10541 |
| Relevant Lines: | 18129 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4533: Add doc to describe read-write split can not support transaction and …
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533#discussion_r386103817
##########
File path: docs/document/content/features/read-write-split/unsupported-items.en.md
##########
@@ -8,3 +8,4 @@ weight = 3
1. Data replication between the master and the slave database.
1. Data inconsistency caused by replication delay between databases.
1. Double or multiple master databases to provide write operation.
+1. The data for transaction across Master and Slave nodes is inconsitent. In the Master-Savle Replication, the master nodes need to be used for both reading and writing in the transaction.
Review comment:
> The data for transaction across Master and Slave nodes is inconsitent
maybe better for:
`The data for transaction across Master and Slave nodes are inconsistent`
> In the Master-Savle Replication, the master nodes need to be used for both reading and writing in the transaction.
maybe better for:
`In the Master-Savle replication model, the master nodes need to be used for both reading and writing in the transaction.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4533: Add doc to describe read-write split can not support transaction and …
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533#issuecomment-592958631
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4533?src=pr&el=h1) Report
> Merging [#4533](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4533?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/1b1cbb1c136e8c0e67ccc830791554f6e26c62ea?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4533?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4533 +/- ##
=========================================
Coverage 55.17% 55.17%
Complexity 331 331
=========================================
Files 954 954
Lines 17960 17960
Branches 3397 3397
=========================================
Hits 9909 9909
Misses 7418 7418
Partials 633 633
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4533?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4533?src=pr&el=footer). Last update [1b1cbb1...efef4ef](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4533?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4533: Add doc to describe read-write split can not support transaction and …
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4533: Add doc to describe read-write split can not support transaction and …
URL: https://github.com/apache/incubator-shardingsphere/pull/4533#issuecomment-592958979
## Pull Request Test Coverage Report for [Build 9887](https://coveralls.io/builds/29046995)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.006%**) to **58.758%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29046995/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29046995) |
| :-- | --: |
| Change from base [Build 954](https://coveralls.io/builds/29045134): | -0.006% |
| Covered Lines: | 10553 |
| Relevant Lines: | 17960 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services