You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Darren Shepherd <da...@godaddy.com> on 2012/08/29 20:23:21 UTC

Review Request: Current working dir for jetty:run Eclipse configuration is half way broken

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6835/
-----------------------------------------------------------

Review request for cloudstack and Hugo Trippaers.


Description
-------

The working dir for the jetty:run in the Eclipse launch config is ${project_loc} is resolves to the current project dir.  So based on where you're clicking its different.  The value should really be ${project_loc:cloud-client-ui}


Diffs
-----

  client/cloudstack-ui.launch 2ab72cc 

Diff: https://reviews.apache.org/r/6835/diff/


Testing
-------


Thanks,

Darren Shepherd


Re: Review Request: Current working dir for jetty:run Eclipse configuration is half way broken

Posted by Hugo Trippaers <ht...@schubergphilis.com>.

> On Aug. 30, 2012, 6:55 a.m., Hugo Trippaers wrote:
> > Ship It!

Committed: https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=34f007f13a38a6c919759adb716eb396ae6cdeaf


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6835/#review10882
-----------------------------------------------------------


On Aug. 29, 2012, 6:23 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6835/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 6:23 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
> The working dir for the jetty:run in the Eclipse launch config is ${project_loc} is resolves to the current project dir.  So based on where you're clicking its different.  The value should really be ${project_loc:cloud-client-ui}
> 
> 
> Diffs
> -----
> 
>   client/cloudstack-ui.launch 2ab72cc 
> 
> Diff: https://reviews.apache.org/r/6835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>


Re: Review Request: Current working dir for jetty:run Eclipse configuration is half way broken

Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6835/#review10882
-----------------------------------------------------------

Ship it!


Ship It!

- Hugo Trippaers


On Aug. 29, 2012, 6:23 p.m., Darren Shepherd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6835/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 6:23 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Description
> -------
> 
> The working dir for the jetty:run in the Eclipse launch config is ${project_loc} is resolves to the current project dir.  So based on where you're clicking its different.  The value should really be ${project_loc:cloud-client-ui}
> 
> 
> Diffs
> -----
> 
>   client/cloudstack-ui.launch 2ab72cc 
> 
> Diff: https://reviews.apache.org/r/6835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Darren Shepherd
> 
>