You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/20 16:16:24 UTC
[GitHub] [hadoop-ozone] runitao opened a new pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
runitao opened a new pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226
## What changes were proposed in this pull request?
People can get more detailed version info about DN in recon UI.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3989
## How was this patch tested?
Test in docker-compose environment
Test in `pnpm run dev` and code is linted with `yarn run lint:fix`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-664605932
@elek Good catch! I have created a jira to track this - https://issues.apache.org/jira/browse/HDDS-4039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-663416483
Hi, thanks for the contributions @runitao, it's very useful for the UI.
It looked good to me, but when I analyzed the network traffic found that the two new fields are added two all the requests as the DatanodeInfo protocol is a shared type.
For example when I do `createKey` or block allocations the new fields are added. Which means that the performance is worse in case of many small keys. I think it can be better to further improve it and add the fields only to the SCM registration type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661479378
Available commands:
* /**close** : Close pending pull request temporary
* /**help** : Show all the available comment commands
* /**label** : add new label to the issue: `/label <label>`
* /**pending** : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending <reason>`
* /**ready** : Dismiss all the blocking reviews by github-actions bot
* /**retest** : provide help on how to trigger new CI build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661518980
To re-run CI checks, please follow these steps with the source branch checked out:
```
git commit --allow-empty -m 'trigger new CI check'
git push
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661254463
//retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-662145107
@runitao Thanks for working on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
runitao commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-664734074
Thanks for your suggestion @elek. And thank you for assigning HDDS-4039 for me, @vivekratnavel, I will fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661254625
No such command. `/retest
` Available commands:
* /**close** : Close pending pull request temporary
* /**help** : Show all the available comment commands
* /**label** : add new label to the issue: `/label <label>`
* /**pending** : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending <reason>`
* /**ready** : Dismiss all the blocking reviews by github-actions bot
* /**retest** : provide help on how to trigger new CI build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661253741
No such command. `retest
` Available commands:
* /**close** : Close pending pull request temporary
* /**help** : Show all the available comment commands
* /**label** : add new label to the issue: `/label <label>`
* /**pending** : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending <reason>`
* /**ready** : Dismiss all the blocking reviews by github-actions bot
* /**retest** : provide help on how to trigger new CI build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao edited a comment on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
runitao edited a comment on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-664734074
Thanks for your suggestion @elek. And thank you for assigning HDDS-4039 to me, @vivekratnavel, I will fix that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
runitao commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661479146
/help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
runitao commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661518739
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
runitao commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-662139582
@vivekratnavel Since the CI passed, can we merge this PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661253600
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao commented on pull request #1226: HDDS-3989. Display revision and build date of DN in recon UI
Posted by GitBox <gi...@apache.org>.
runitao commented on pull request #1226:
URL: https://github.com/apache/hadoop-ozone/pull/1226#issuecomment-661603126
```
Log: /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/log.html
Report: /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/report.html
cp: cannot stat '/mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/upgrade/result/*.out*': No such file or directory
Log: /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/result/log.html
Report: /mnt/ozone/hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT/compose/result/report.html
Exception in thread "main"
##[error]Process completed with exit code 1.
```
trigger CI again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org