You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Ladislav Thon <no...@github.com> on 2016/01/21 11:36:00 UTC

[jclouds-labs] [JCLOUDS-1063] make Role.OSVirtualHardDisk.sourceImageName nullable (#232)

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/232

-- Commit Summary --

  * [JCLOUDS-1063] make Role.OSVirtualHardDisk.sourceImageName nullable

-- File Changes --

    M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Role.java (1)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/232.patch
https://github.com/jclouds/jclouds-labs/pull/232.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/232

Re: [jclouds-labs] [JCLOUDS-1063] make Role.OSVirtualHardDisk.sourceImageName nullable (#232)

Posted by Ignasi Barrera <no...@github.com>.

Pushed to master as [6d3363fd](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/6d3363fd). Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/232#issuecomment-173546512

Re: [jclouds-labs] [JCLOUDS-1063] make Role.OSVirtualHardDisk.sourceImageName nullable (#232)

Posted by Ladislav Thon <no...@github.com>.

Done. I added the exact XML received from Azure (actually the _Role_ part of the XML) that caused the problem. Some fields redacted, of course.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/232#issuecomment-173540685

Re: [jclouds-labs] [JCLOUDS-1063] make Role.OSVirtualHardDisk.sourceImageName nullable (#232)

Posted by Ignasi Barrera <no...@github.com>.

Add a test to make sure this is fixed, or modify [the existing one](https://github.com/jclouds/jclouds-labs/blob/master/azurecompute/src/test/java/org/jclouds/azurecompute/xml/RoleHandlerTest.java)?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/232#issuecomment-173535179

Re: [jclouds-labs] [JCLOUDS-1063] make Role.OSVirtualHardDisk.sourceImageName nullable (#232)

Posted by Ignasi Barrera <no...@github.com>.

Closed #232.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/232#event-521573178