You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2023/11/10 16:52:35 UTC

[PR] Fix check for using default values [daffodil-vscode]

shanedell opened a new pull request, #897:
URL: https://github.com/apache/daffodil-vscode/pull/897

   Fix check for using default values
   
   - The check used for seeing if default values or not was working improperly as it was checking the boolean-ness of a variable.
     - So, if the value provided was false it would still use a default value.
     - To fix the issue we need to check if accessing the varaible returns undefined meaning it wasn't provided so use the default then.
   
   Closes #852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix check for using default values [daffodil-vscode]

Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #897:
URL: https://github.com/apache/daffodil-vscode/pull/897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org