[GitHub] [spark] HyukjinKwon commented on a change in pull request #33570: [WIP][SPARK-36338][PYTHON][SQL] Move distributed-sequence implementation to Scala side

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #33570:
URL: https://github.com/apache/spark/pull/33570#discussion_r678918389



##########
File path: python/pyspark/pandas/indexes/base.py
##########
@@ -2475,7 +2469,7 @@ def insert(self, loc: int, item: Any) -> "Index":
                 scol_for(sdf, col) for col in self._internal.index_spark_column_names
             ],
             index_names=self._internal.index_names,
-            index_fields=[field.copy(nullable=True) for field in self._internal.index_fields],
+            index_fields=[InternalField(field.dtype) for field in self._internal.index_fields],

Review comment:
       This actually fixes a test failure (by `Index.insert` -> `DataFrame[:loc]` -> attach distributed sequence index)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org