You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/17 02:00:31 UTC

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7683: change(authz-keycloak): remove deprecated audience

tzssangglass commented on code in PR #7683:
URL: https://github.com/apache/apisix/pull/7683#discussion_r947383438


##########
t/plugin/authz-keycloak.t:
##########
@@ -74,32 +74,7 @@ done
 
 
 
-=== TEST 3: minimal valid configuration with audience
---- config
-    location /t {
-        content_by_lua_block {
-            local plugin = require("apisix.plugins.authz-keycloak")
-            local ok, err = plugin.check_schema({
-                                audience = "foo",

Review Comment:
   we have a test case cover `client_id`, ref: https://github.com/apache/apisix/blob/d3d6151c80fcdc162401429bb0920b381d3f2dd7/t/plugin/authz-keycloak.t#L52-L73
   
   so just remove this is ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org