You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/12 11:57:38 UTC

[GitHub] [dubbo-go] cvictory commented on a diff in pull request #1820: Fix: decode net stream bytes as getty rule

cvictory commented on code in PR #1820:
URL: https://github.com/apache/dubbo-go/pull/1820#discussion_r848350127


##########
protocol/dubbo/impl/codec.go:
##########
@@ -157,6 +157,9 @@ func (c *ProtocolCodec) Decode(p *DubboPackage) error {
 			return err
 		}
 	}
+	if c.reader.Size() < p.GetBodyLen() {

Review Comment:
   r.reader.Size() < p.GetBodyLen() + HEADER_LENGTH  
   是不是应该这样?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org