You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "nicolasguyomar (via GitHub)" <gi...@apache.org> on 2024/05/27 13:11:16 UTC

[PR] MINOR: Log client idle disconnect events at DEBUG level [kafka]

nicolasguyomar opened a new pull request, #16089:
URL: https://github.com/apache/kafka/pull/16089

   We recently increased that log verbosity from INFO to DEBUG, but this is causing some confusion among users when an idle connection is disconnected, which is a normal activity. This is a proposal to make it clear that the connection being disconnect has expired, thank you
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Log client idle disconnect events at DEBUG level [kafka]

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #16089:
URL: https://github.com/apache/kafka/pull/16089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Log client idle disconnect events at DEBUG level [kafka]

Posted by "nicolasguyomar (via GitHub)" <gi...@apache.org>.
nicolasguyomar commented on code in PR #16089:
URL: https://github.com/apache/kafka/pull/16089#discussion_r1648995775


##########
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##########
@@ -995,7 +995,11 @@ private void handleApiVersionsResponse(List<ClientResponse> responses,
     private void handleDisconnections(List<ClientResponse> responses, long now) {
         for (Map.Entry<String, ChannelState> entry : this.selector.disconnected().entrySet()) {
             String node = entry.getKey();
-            log.info("Node {} disconnected.", node);
+            if (null != entry.getValue() && entry.getValue() == ChannelState.EXPIRED) {
+                log.debug("Idle connection to node {} disconnected.", node);
+            } else {
+                log.info("Node {} disconnected.", node);
+            }
             processDisconnection(responses, node, now, entry.getValue());

Review Comment:
   excuse me @dimitarndimitrov, I managed to confuse myself, you are correct of course :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org