You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2019/10/25 21:54:23 UTC

[kudu-CR] [docs] Fix formatting in catalog manager design page 

Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14550


Change subject: [docs] Fix formatting in catalog manager design page
......................................................................

[docs] Fix formatting in catalog manager design page

Issues:
- Title incorrectly rendered
- Bullet list under Table creation not correctly rendered
https://github.com/apache/kudu/blob/master/docs/design-docs/master.md#table-creation
- Section headers not correctly marked

Tests:
- Verified with a markdown plugin on chrome

Change-Id: I4ac7df450b43d97e3dbfb3275708b3b47a0dc1e6
---
M docs/design-docs/master.md
1 file changed, 19 insertions(+), 30 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14550/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ac7df450b43d97e3dbfb3275708b3b47a0dc1e6
Gerrit-Change-Number: 14550
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>

[kudu-CR] [docs] Fix formatting in catalog manager design page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14550 )

Change subject: [docs] Fix formatting in catalog manager design page
......................................................................

[docs] Fix formatting in catalog manager design page

Issues:
- Title incorrectly rendered
- Bullet list under Table creation not correctly rendered
https://github.com/apache/kudu/blob/master/docs/design-docs/master.md#table-creation
- Section headers not correctly marked

Tests:
- Verified with a markdown plugin on chrome

Change-Id: I4ac7df450b43d97e3dbfb3275708b3b47a0dc1e6
Reviewed-on: http://gerrit.cloudera.org:8080/14550
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/design-docs/master.md
1 file changed, 19 insertions(+), 30 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ac7df450b43d97e3dbfb3275708b3b47a0dc1e6
Gerrit-Change-Number: 14550
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] Fix formatting in catalog manager design page

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14550 )

Change subject: [docs] Fix formatting in catalog manager design page
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac7df450b43d97e3dbfb3275708b3b47a0dc1e6
Gerrit-Change-Number: 14550
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 25 Oct 2019 21:57:18 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] Fix formatting in catalog manager design page

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14550 )

Change subject: [docs] Fix formatting in catalog manager design page
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14550/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14550/1//COMMIT_MSG@15
PS1, Line 15: Tests:
nit: In the future, when making docs changes (especially formatting ones), best practice is to upload the change to your own personal branch and paste a github link to it.



-- 
To view, visit http://gerrit.cloudera.org:8080/14550
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ac7df450b43d97e3dbfb3275708b3b47a0dc1e6
Gerrit-Change-Number: 14550
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 25 Oct 2019 23:26:22 +0000
Gerrit-HasComments: Yes