You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/21 17:23:32 UTC
[GitHub] [airflow] dmayle opened a new issue #8495: Allow configuration of args vs command for to support container entrypoint in kubernetes executor
dmayle opened a new issue #8495:
URL: https://github.com/apache/airflow/issues/8495
**Description**
Please add an option to the kubernetes config to support using a container entrypoint. Right now, the kubernetes executor runs the worker and sets the command option on the pod. This overrides the container's entrypoint, which prevents scripts from properly setting up the airflow environment.
**Use case / motivation**
Some airflow containers (notable puckel/docker-airflow) use an entrypoint to properly setup the airflow environment. This allows things like constructing the SQL Alchemy connection string from database parameters.
**Related Issues**
Not in Airflow (there's a similar issue in Spark)
**Other**
The most likely place to fix this is in worker_configuration.make_pod, checking a value from kube_executor_config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-671088585
@dmayle @matthieu-foucault @humbledude Would you like to contribute this change to the project? This looks like a much needed change so I'd love to help with the review.
CC: @dimberman
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cris-b commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
cris-b commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-744515012
This was fixed in master under #12766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dszakallas commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
dszakallas commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-688842142
I need this feature as well. As an alternative to what @humbledude proposed we could assume that the docker image has a command (docker entrypoint) that 'behaves like airflow' and only specify the airflow command's args in the arg field so that when the flag enabling this feature is set we send sth like:
```
"command": [],
"args": ["run", "my-dag", "my-task", ...]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
dimberman closed issue #8495:
URL: https://github.com/apache/airflow/issues/8495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] humbledude commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
humbledude commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-653378740
https://github.com/apache/airflow/blob/72d5a58fd734cf4a02e351210b7db5ae2fae7e4e/airflow/executors/kubernetes_executor.py#L470
this could be "args"...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-773653435
This is fixed in master and should be released as a part of either 2.0.1 or 2.0.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #8495: Allow configuration of args vs command for to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-617300606
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
dimberman commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-773653435
This is fixed in master and should be released as a part of either 2.0.1 or 2.0.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor
Posted by GitBox <gi...@apache.org>.
dimberman closed issue #8495:
URL: https://github.com/apache/airflow/issues/8495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org