You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 16:24:37 UTC

[GitHub] [arrow] arw2019 commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

arw2019 commented on a change in pull request #8294:
URL: https://github.com/apache/arrow/pull/8294#discussion_r523059162



##########
File path: cpp/src/arrow/compute/api_aggregate.cc
##########
@@ -41,8 +41,12 @@ Result<Datum> MinMax(const Datum& value, const MinMaxOptions& options, ExecConte
   return CallFunction("min_max", {value}, &options, ctx);
 }
 
-Result<Datum> Mode(const Datum& value, const ModeOptions& options, ExecContext* ctx) {
-  return CallFunction("mode", {value}, &options, ctx);
+Result<Datum> Any(const Datum& value, ExecContext* ctx) {
+  return CallFunction("any", {value}, ctx);
+}
+
+Result<Datum> Mode(const Datum& value, ExecContext* ctx) {

Review comment:
       Thanks - yes, that's the problem!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org