You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/12/28 23:00:13 UTC
Review Request 41754: Added reference to docker registry bearer token
spec.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41754/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Added reference to docker registry bearer token spec.
Diffs
-----
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 93e7b3b466283a7732290419060ebedad3445133
src/slave/containerizer/mesos/provisioner/docker/token_manager.hpp 3a01aca659ca2b31d0b31ec17382c953cbfc1c2b
Diff: https://reviews.apache.org/r/41754/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 41754: Added reference to docker registry bearer
token spec.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41754/#review112347
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (lines 259 - 261)
<https://reviews.apache.org/r/41754/#comment172827>
No need for this comment here. What does that mean? I'll remove it for you.
src/slave/containerizer/mesos/provisioner/docker/token_manager.hpp (line 108)
<https://reviews.apache.org/r/41754/#comment172828>
I would put that above class Token. I'll fix that for you.
- Jie Yu
On Dec. 28, 2015, 10 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41754/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added reference to docker registry bearer token spec.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 93e7b3b466283a7732290419060ebedad3445133
> src/slave/containerizer/mesos/provisioner/docker/token_manager.hpp 3a01aca659ca2b31d0b31ec17382c953cbfc1c2b
>
> Diff: https://reviews.apache.org/r/41754/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 41754: Added reference to docker registry bearer
token spec.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41754/#review112080
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41754]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 28, 2015, 10 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41754/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added reference to docker registry bearer token spec.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 93e7b3b466283a7732290419060ebedad3445133
> src/slave/containerizer/mesos/provisioner/docker/token_manager.hpp 3a01aca659ca2b31d0b31ec17382c953cbfc1c2b
>
> Diff: https://reviews.apache.org/r/41754/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>