You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "GungnirLaevatain (GitHub)" <gi...@apache.org> on 2020/01/03 03:16:34 UTC
[GitHub] [dubbo] GungnirLaevatain opened pull request #5577: remove
duplicate code in UrlUtils#parseURL
## What is the purpose of the change
``defaultProtocol`` won't be empty, because of [this](https://github.com/GungnirLaevatain/dubbo/blob/3b5dc6e53b04d313611ed907c0ba270f6ff06444/dubbo-common/src/main/java/org/apache/dubbo/common/utils/UrlUtils.java#L89)
## Brief changelog
``org.apache.dubbo.common.utils.UrlUtils``
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5577 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org